]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/panel: himax-hx83102: Add a check to prevent NULL pointer dereference
authorZhang Zekun <zhangzekun11@huawei.com>
Fri, 25 Oct 2024 07:34:08 +0000 (15:34 +0800)
committerNeil Armstrong <neil.armstrong@linaro.org>
Fri, 13 Dec 2024 09:51:24 +0000 (10:51 +0100)
drm_mode_duplicate() could return NULL due to lack of memory,
which will then call NULL pointer dereference. Add a check to
prevent it.

Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102: Break out as separate driver")
Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20241025073408.27481-3-zhangzekun11@huawei.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241025073408.27481-3-zhangzekun11@huawei.com
drivers/gpu/drm/panel/panel-himax-hx83102.c

index 8b48bba181316c6da3978823cee9f589d1ffac5c..3644a7544b935d4159d375c28d4aea654aa7156d 100644 (file)
@@ -565,6 +565,8 @@ static int hx83102_get_modes(struct drm_panel *panel,
        struct drm_display_mode *mode;
 
        mode = drm_mode_duplicate(connector->dev, m);
+       if (!mode)
+               return -ENOMEM;
 
        mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
        drm_mode_set_name(mode);