f2fs: check the generic conditions first

[ Upstream commit e23ab8028de0d92df5921a570f5212c0370db3b5 ]

Let's return errors caught by the generic checks. This fixes generic/494 where
it expects to see EBUSY by setattr_prepare instead of EINVAL by f2fs for active
swapfile.

Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 696131e655ed381283668635210f11bc4c2fca3d..bb3fd6a8416fd35608afc982ce17a9d5fb631749 100644 (file)
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1047,6 +1047,18 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
        if (unlikely(f2fs_cp_error(F2FS_I_SB(inode))))
                return -EIO;
 
+       err = setattr_prepare(idmap, dentry, attr);
+       if (err)
+               return err;
+
+       err = fscrypt_prepare_setattr(dentry, attr);
+       if (err)
+               return err;
+
+       err = fsverity_prepare_setattr(dentry, attr);
+       if (err)
+               return err;
+
        if (unlikely(IS_IMMUTABLE(inode)))
                return -EPERM;
 
@@ -1065,18 +1077,6 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
                        return -EINVAL;
        }
 
-       err = setattr_prepare(idmap, dentry, attr);
-       if (err)
-               return err;
-
-       err = fscrypt_prepare_setattr(dentry, attr);
-       if (err)
-               return err;
-
-       err = fsverity_prepare_setattr(dentry, attr);
-       if (err)
-               return err;
-
        if (is_quota_modification(idmap, inode, attr)) {
                err = f2fs_dquot_initialize(inode);
                if (err)