]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests: af_unix: don't use SKIP for expected failures
authorJakub Kicinski <kuba@kernel.org>
Sun, 23 Nov 2025 02:16:01 +0000 (18:16 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Nov 2025 03:07:51 +0000 (19:07 -0800)
netdev CI reserves SKIP in selftests for cases which can't be executed
due to setup issues, like missing or old commands. Tests which are
expected to fail must use XFAIL.

Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20251123021601.158709-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/af_unix/unix_connreset.c

index bffef2b54bfd1937b75b0366fee756f0dce92c7c..6eb936207b3129941e4f0a8cd4878292405e8464 100644 (file)
@@ -161,8 +161,12 @@ TEST_F(unix_sock, reset_closed_embryo)
        char buf[16] = {};
        ssize_t n;
 
-       if (variant->socket_type == SOCK_DGRAM)
-               SKIP(return, "This test only applies to SOCK_STREAM and SOCK_SEQPACKET");
+       if (variant->socket_type == SOCK_DGRAM) {
+               snprintf(_metadata->results->reason,
+                        sizeof(_metadata->results->reason),
+                        "Test only applies to SOCK_STREAM and SOCK_SEQPACKET");
+               exit(KSFT_XFAIL);
+       }
 
        /* Close server without accept()ing */
        close(self->server);