]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol
authorRandy Dunlap <rdunlap@infradead.org>
Sat, 9 Mar 2024 22:45:38 +0000 (14:45 -0800)
committerKalle Valo <kvalo@kernel.org>
Tue, 12 Mar 2024 15:33:41 +0000 (17:33 +0200)
CONFIG_SSB_DEBUG is used in one header file and nowhere else, so
remove it and the now-empty inline function that contained it. Also
remove the call to the empty inline function. The empty "default:"
case is kept to prevent 2 compiler warnings:

  drivers/ssb/main.c:1133:9: warning: enumeration value 'SSB_BUSTYPE_PCMCIA' not handled in switch [-Wswitch]
  drivers/ssb/main.c:1133:9: warning: enumeration value 'SSB_BUSTYPE_SDIO' not handled in switch [-Wswitch]

Reported-by: Ying Sun <sunying@isrc.iscas.ac.cn>
Link: https://lore.kernel.org/lkml/4e8525fe.607e2.18a8ddfdce8.Coremail.sunying@isrc.iscas.ac.cn/
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Michael Büsch <m@bues.ch>
Cc: linux-wireless@vger.kernel.org
Cc: Kalle Valo <kvalo@kernel.org>
Acked-by: Michael Büsch <m@bues.ch>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240309224540.22682-1-rdunlap@infradead.org
drivers/ssb/main.c
include/linux/ssb/ssb.h

index bdb6595ffd2d5194ddee2fe0e9f692bf2deeceb1..8210bf28a3404414720528e27edbea059f12cf26 100644 (file)
@@ -1146,7 +1146,6 @@ u32 ssb_dma_translation(struct ssb_device *dev)
                                return SSB_PCI_DMA;
                }
        default:
-               __ssb_dma_not_implemented(dev);
        }
        return 0;
 }
index 1f326da289d3a6323d496142ce5110e38dbd3d7e..a2257380c3f1ceb957cda911ff3d119f2be00135 100644 (file)
@@ -621,14 +621,6 @@ extern u32 ssb_dma_translation(struct ssb_device *dev);
 #define SSB_DMA_TRANSLATION_MASK       0xC0000000
 #define SSB_DMA_TRANSLATION_SHIFT      30
 
-static inline void __cold __ssb_dma_not_implemented(struct ssb_device *dev)
-{
-#ifdef CONFIG_SSB_DEBUG
-       printk(KERN_ERR "SSB: BUG! Calling DMA API for "
-              "unsupported bustype %d\n", dev->bus->bustype);
-#endif /* DEBUG */
-}
-
 #ifdef CONFIG_SSB_PCIHOST
 /* PCI-host wrapper driver */
 extern int ssb_pcihost_register(struct pci_driver *driver);