]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
xdp: Remove unused mem_return_failed event
authorSteven Rostedt <rostedt@goodmis.org>
Thu, 29 May 2025 20:05:50 +0000 (16:05 -0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 2 Jun 2025 17:12:26 +0000 (13:12 -0400)
The change to allow page_pool to handle its own page destruction instead
of relying on XDP removed the trace_mem_return_failed() tracepoint caller,
but did not remove the mem_return_failed trace event. As trace events take
up memory when they are created regardless of if they are used or not,
having this unused event around wastes around 5K of memory.

Remove the unused event.

Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/
Cc: netdev <netdev@vger.kernel.org>
Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Link: https://lore.kernel.org/20250529160550.1f888b15@gandalf.local.home
Fixes: c3f812cea0d7 ("page_pool: do not release pool until inflight == 0.")
Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
include/trace/events/xdp.h

index a7e5452b5d21502781027c1824c405c158c5449b..d3ef86c97ae3d00518c136e3f214b3c1245acf37 100644 (file)
@@ -379,32 +379,6 @@ TRACE_EVENT(mem_connect,
        )
 );
 
-TRACE_EVENT(mem_return_failed,
-
-       TP_PROTO(const struct xdp_mem_info *mem,
-                const struct page *page),
-
-       TP_ARGS(mem, page),
-
-       TP_STRUCT__entry(
-               __field(const struct page *,    page)
-               __field(u32,            mem_id)
-               __field(u32,            mem_type)
-       ),
-
-       TP_fast_assign(
-               __entry->page           = page;
-               __entry->mem_id         = mem->id;
-               __entry->mem_type       = mem->type;
-       ),
-
-       TP_printk("mem_id=%d mem_type=%s page=%p",
-                 __entry->mem_id,
-                 __print_symbolic(__entry->mem_type, __MEM_TYPE_SYM_TAB),
-                 __entry->page
-       )
-);
-
 TRACE_EVENT(bpf_xdp_link_attach_failed,
 
        TP_PROTO(const char *msg),