]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: gpib: pc2: avoid calling undefined dma_free()
authorArnd Bergmann <arnd@arndb.de>
Wed, 16 Oct 2024 11:15:17 +0000 (11:15 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 19 Oct 2024 07:57:03 +0000 (09:57 +0200)
On architectures that don't support the ISA DMA API, this causes a build
failure. The corresponding dma_alloc() call is already in an #ifdef,
so use the same one for dma_free().

Note that nothing seems to set PC2_DMA, so parts of this driver
are likely unused. ISA DMA usually does not work on PCI or PCMCIA
devices, only on physical ISA slots.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20241016111521.1143191-4-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/pc2/pc2_gpib.c

index cd70cedb4899d72ecc9d7c3ebfce5d384793e071..7b3b34f4734168eb01859ae1bfe428dcb6fb8783 100644 (file)
@@ -462,8 +462,10 @@ void pc2_detach(gpib_board_t *board)
 
        if (pc2_priv) {
                nec_priv = &pc2_priv->nec7210_priv;
+#ifdef PC2_DMA
                if (nec_priv->dma_channel)
                        free_dma(nec_priv->dma_channel);
+#endif
                gpib_free_pseudo_irq(board);
                if (pc2_priv->irq)
                        free_irq(pc2_priv->irq, board);
@@ -596,8 +598,10 @@ static void pc2a_common_detach(gpib_board_t *board, unsigned int num_registers)
 
        if (pc2_priv) {
                nec_priv = &pc2_priv->nec7210_priv;
+#ifdef PC2_DMA
                if (nec_priv->dma_channel)
                        free_dma(nec_priv->dma_channel);
+#endif
                gpib_free_pseudo_irq(board);
                if (pc2_priv->irq)
                        free_irq(pc2_priv->irq, board);