]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: Kconfig: remove unnecessary selection of CRC32
authorEric Biggers <ebiggers@google.com>
Mon, 14 Apr 2025 17:40:18 +0000 (10:40 -0700)
committerWill Deacon <will@kernel.org>
Tue, 29 Apr 2025 15:20:39 +0000 (16:20 +0100)
The selection of CRC32 by ARM64 was added by commit 7481cddf29ed
("arm64/lib: add accelerated crc32 routines") as a workaround for the
fact that, at the time, the CRC32 library functions used weak symbols to
allow architecture-specific overrides.  That only worked when CRC32 was
built-in, and thus ARM64 was made to just force CRC32 to built-in.

Now that the CRC32 library no longer uses weak symbols, that no longer
applies.  And the selection does not fulfill a user dependency either;
those all have their own selections from other options.  Therefore, the
selection of CRC32 by ARM64 is no longer necessary.  Remove it.

Note that this does not necessarily result in CRC32 no longer being set
to y, as it still tends to get selected by something else anyway.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20250414174018.6359-1-ebiggers@kernel.org
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/Kconfig

index a182295e6f08bfa0f3e6f630dc4adfe797a4d273..14073b0094c12641bcb924eb36446ce9d17f4a95 100644 (file)
@@ -134,7 +134,6 @@ config ARM64
        select COMMON_CLK
        select CPU_PM if (SUSPEND || CPU_IDLE)
        select CPUMASK_OFFSTACK if NR_CPUS > 256
-       select CRC32
        select DCACHE_WORD_ACCESS
        select DYNAMIC_FTRACE if FUNCTION_TRACER
        select DMA_BOUNCE_UNALIGNED_KMALLOC