]> git.ipfire.org Git - thirdparty/iptables.git/commitdiff
arptables: fix rule deletion/compare
authorFlorian Westphal <fw@strlen.de>
Mon, 5 Nov 2018 16:01:36 +0000 (17:01 +0100)
committerFlorian Westphal <fw@strlen.de>
Mon, 12 Nov 2018 13:53:24 +0000 (14:53 +0100)
arptables -D fails most of the time, as we compared
source mask with target mask.

Signed-off-by: Florian Westphal <fw@strlen.de>
iptables/nft-arp.c

index f9352297d83b0c49a754a0b145136c6fe8c941c2..675f0eb9daa6cbe0081386fc0385150ce54a38b0 100644 (file)
@@ -637,7 +637,8 @@ static bool nft_arp_is_same(const void *data_a,
 
        if (a->arp.src.s_addr != b->arp.src.s_addr
            || a->arp.tgt.s_addr != b->arp.tgt.s_addr
-           || a->arp.smsk.s_addr != b->arp.tmsk.s_addr
+           || a->arp.smsk.s_addr != b->arp.smsk.s_addr
+           || a->arp.tmsk.s_addr != b->arp.tmsk.s_addr
            || a->arp.arpro != b->arp.arpro
            || a->arp.flags != b->arp.flags
            || a->arp.invflags != b->arp.invflags) {