]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Fix uninitialized dnsheader in the rings unit tests
authorRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 11 Jan 2021 10:04:38 +0000 (11:04 +0100)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 11 Jan 2021 10:04:38 +0000 (11:04 +0100)
pdns/dnsdistdist/test-dnsdistrings_cc.cc

index 1213377f01bc3b3fa4891d3528db30abbb13a875..09181c221f3940ca2a381a0ba6f37e3e7a9a500b 100644 (file)
@@ -24,6 +24,7 @@ static void test_ring(size_t maxEntries, size_t numberOfShards, size_t nbLockTri
   }
 
   dnsheader dh;
+  memset(&dh, 0, sizeof(dh));
   DNSName qname("rings.powerdns.com.");
   ComboAddress requestor1("192.0.2.1");
   ComboAddress requestor2("192.0.2.2");
@@ -163,7 +164,7 @@ static void ringReaderThread(Rings& rings, std::atomic<bool>& done, size_t numbe
 #endif
 }
 
-static void ringWriterThread(Rings& rings, size_t numberOfEntries, const Rings::Query query, const Rings::Response response)
+static void ringWriterThread(Rings& rings, size_t numberOfEntries, const Rings::Query& query, const Rings::Response& response)
 {
   for (size_t idx = 0; idx < numberOfEntries; idx++) {
     rings.insertQuery(query.when, query.requestor, query.name, query.qtype, query.size, query.dh);
@@ -181,6 +182,7 @@ BOOST_AUTO_TEST_CASE(test_Rings_Threaded) {
   struct timespec now;
   gettime(&now);
   dnsheader dh;
+  memset(&dh, 0, sizeof(dh));
   dh.id = htons(4242);
   dh.qr = 0;
   dh.tc = 0;