]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: platform: rzg2l-cru: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:15:06 +0000 (14:15 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:16 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./platform/renesas/rzg2l-cru/rzg2l-csi2.c:307:30-37: WARNING: Consider using %pe to print PTR_ERR()
./platform/renesas/rzg2l-cru/rzg2l-csi2.c:726:30-37: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c

index 1520211e74185fea3bca85f36239254f6b4651db..0fbdae280fdc49f963269a4bdaea38ff2e51884e 100644 (file)
@@ -303,8 +303,8 @@ static int rzg2l_csi2_calc_mbps(struct rzg2l_csi2 *csi2)
 
        remote_pad = media_pad_remote_pad_unique(&csi2->pads[RZG2L_CSI2_SINK]);
        if (IS_ERR(remote_pad)) {
-               dev_err(csi2->dev, "can't get source pad of %s (%ld)\n",
-                       csi2->remote_source->name, PTR_ERR(remote_pad));
+               dev_err(csi2->dev, "can't get source pad of %s (%pe)\n",
+                       csi2->remote_source->name, remote_pad);
                return PTR_ERR(remote_pad);
        }
 
@@ -722,8 +722,8 @@ static int rzg2l_csi2_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
 
        remote_pad = media_pad_remote_pad_unique(&csi2->pads[RZG2L_CSI2_SINK]);
        if (IS_ERR(remote_pad)) {
-               dev_err(csi2->dev, "can't get source pad of %s (%ld)\n",
-                       csi2->remote_source->name, PTR_ERR(remote_pad));
+               dev_err(csi2->dev, "can't get source pad of %s (%pe)\n",
+                       csi2->remote_source->name, remote_pad);
                return PTR_ERR(remote_pad);
        }
        return v4l2_subdev_call(csi2->remote_source, pad, get_frame_desc,