]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drbd: don't set max_write_zeroes_sectors in decide_on_discard_support
authorChristoph Hellwig <hch@lst.de>
Wed, 6 Mar 2024 14:03:30 +0000 (15:03 +0100)
committerJens Axboe <axboe@kernel.dk>
Wed, 6 Mar 2024 15:30:34 +0000 (08:30 -0700)
fixup_write_zeroes always overrides the max_write_zeroes_sectors value
a little further down the callchain, so don't bother to setup a limit
in decide_on_discard_support.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Philipp Reisner <philipp.reisner@linbit.com>
Reviewed-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Tested-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
Link: https://lore.kernel.org/r/20240306140332.623759-6-philipp.reisner@linbit.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/drbd/drbd_nl.c

index 0f40fdee0899718feb9d53c50b0015be3527ac1c..a79b7fe5335de4763dd537a30b2bde367a081e20 100644 (file)
@@ -1260,7 +1260,6 @@ static void decide_on_discard_support(struct drbd_device *device,
        blk_queue_discard_granularity(q, 512);
        max_discard_sectors = drbd_max_discard_sectors(connection);
        blk_queue_max_discard_sectors(q, max_discard_sectors);
-       blk_queue_max_write_zeroes_sectors(q, max_discard_sectors);
        return;
 
 not_supported: