]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mfd: si476x: Add GPIOLIB_LEGACY dependency
authorArnd Bergmann <arnd@arndb.de>
Fri, 8 Aug 2025 15:17:57 +0000 (17:17 +0200)
committerLee Jones <lee@kernel.org>
Wed, 1 Oct 2025 09:28:30 +0000 (10:28 +0100)
This driver uses the legacy gpiolib interfaces to get gpio
numbers from platform data:

drivers/mfd/si476x-i2c.c: In function 'si476x_core_start':
   drivers/mfd/si476x-i2c.c:133:21: error: implicit declaration of function 'gpio_is_valid'; did you mean 'uuid_is_valid'? [-Werror=implicit-function-declaration]
     133 |                 if (gpio_is_valid(core->gpio_reset))

There are no in-tree users of this driver, so nothing defines
the platform data.

Add a dependency on GPIOLIB_LEGACY for the moment to avoid the build
failure, and make sure the sound driver does not get built without the
mfd portion either pass that dependency along.

Alternatively, we could remove the mfd driver along with the radio and
sound portions.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507231653.UFlH2dMO-lkp@intel.com/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250808151822.536879-14-arnd@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/Kconfig
sound/soc/codecs/Kconfig

index 4b04adeb32071c77407eb571c3fac7c3a7cc23f4..97ab36d8a4c9e0c9e0379cb9750e13e62234a60d 100644 (file)
@@ -1426,6 +1426,7 @@ config MFD_SEC_I2C
 config MFD_SI476X_CORE
        tristate "Silicon Laboratories 4761/64/68 AM/FM radio."
        depends on I2C
+       depends on GPIOLIB_LEGACY
        select MFD_CORE
        select REGMAP_I2C
        help
index 6d7e4725d89cd33647770e4f2c4e81445b8335ce..dfe907c62604c2d631cc262b91723a4aa10e2628 100644 (file)
@@ -1902,6 +1902,7 @@ config SND_SOC_SGTL5000
 
 config SND_SOC_SI476X
        tristate
+       depends on MFD_SI476X_CORE
 
 config SND_SOC_SIGMADSP
        tristate