]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 7 Aug 2018 13:23:33 +0000 (15:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 7 Aug 2018 13:23:33 +0000 (15:23 +0200)
added patches:
acpi-pci-bail-early-in-acpi_pci_add_bus-if-there-is-no-acpi-handle.patch
ext4-fix-false-negatives-and-false-positives-in-ext4_check_descriptors.patch
i2c-imx-fix-reinit_completion-use.patch
ring_buffer-tracing-inherit-the-tracing-setting-to-next-ring-buffer.patch

queue-4.4/acpi-pci-bail-early-in-acpi_pci_add_bus-if-there-is-no-acpi-handle.patch [new file with mode: 0644]
queue-4.4/ext4-fix-false-negatives-and-false-positives-in-ext4_check_descriptors.patch [new file with mode: 0644]
queue-4.4/i2c-imx-fix-reinit_completion-use.patch [new file with mode: 0644]
queue-4.4/ring_buffer-tracing-inherit-the-tracing-setting-to-next-ring-buffer.patch [new file with mode: 0644]
queue-4.4/series

diff --git a/queue-4.4/acpi-pci-bail-early-in-acpi_pci_add_bus-if-there-is-no-acpi-handle.patch b/queue-4.4/acpi-pci-bail-early-in-acpi_pci_add_bus-if-there-is-no-acpi-handle.patch
new file mode 100644 (file)
index 0000000..81066f0
--- /dev/null
@@ -0,0 +1,42 @@
+From a0040c0145945d3bd203df8fa97f6dfa819f3f7d Mon Sep 17 00:00:00 2001
+From: Vitaly Kuznetsov <vkuznets@redhat.com>
+Date: Thu, 14 Sep 2017 16:50:14 +0200
+Subject: ACPI / PCI: Bail early in acpi_pci_add_bus() if there is no ACPI handle
+
+From: Vitaly Kuznetsov <vkuznets@redhat.com>
+
+commit a0040c0145945d3bd203df8fa97f6dfa819f3f7d upstream.
+
+Hyper-V instances support PCI pass-through which is implemented through PV
+pci-hyperv driver. When a device is passed through, a new root PCI bus is
+created in the guest. The bus sits on top of VMBus and has no associated
+information in ACPI. acpi_pci_add_bus() in this case proceeds all the way
+to acpi_evaluate_dsm(), which reports
+
+  ACPI: \: failed to evaluate _DSM (0x1001)
+
+While acpi_pci_slot_enumerate() and acpiphp_enumerate_slots() are protected
+against ACPI_HANDLE() being NULL and do nothing, acpi_evaluate_dsm() is not
+and gives us the error. It seems the correct fix is to not do anything in
+acpi_pci_add_bus() in such cases.
+
+Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
+Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
+Cc: Sinan Kaya <okaya@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/pci/pci-acpi.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/pci/pci-acpi.c
++++ b/drivers/pci/pci-acpi.c
+@@ -543,7 +543,7 @@ void acpi_pci_add_bus(struct pci_bus *bu
+       union acpi_object *obj;
+       struct pci_host_bridge *bridge;
+-      if (acpi_pci_disabled || !bus->bridge)
++      if (acpi_pci_disabled || !bus->bridge || !ACPI_HANDLE(bus->bridge))
+               return;
+       acpi_pci_slot_enumerate(bus);
diff --git a/queue-4.4/ext4-fix-false-negatives-and-false-positives-in-ext4_check_descriptors.patch b/queue-4.4/ext4-fix-false-negatives-and-false-positives-in-ext4_check_descriptors.patch
new file mode 100644 (file)
index 0000000..6561535
--- /dev/null
@@ -0,0 +1,55 @@
+From 44de022c4382541cebdd6de4465d1f4f465ff1dd Mon Sep 17 00:00:00 2001
+From: Theodore Ts'o <tytso@mit.edu>
+Date: Sun, 8 Jul 2018 19:35:02 -0400
+Subject: ext4: fix false negatives *and* false positives in ext4_check_descriptors()
+
+From: Theodore Ts'o <tytso@mit.edu>
+
+commit 44de022c4382541cebdd6de4465d1f4f465ff1dd upstream.
+
+Ext4_check_descriptors() was getting called before s_gdb_count was
+initialized.  So for file systems w/o the meta_bg feature, allocation
+bitmaps could overlap the block group descriptors and ext4 wouldn't
+notice.
+
+For file systems with the meta_bg feature enabled, there was a
+fencepost error which would cause the ext4_check_descriptors() to
+incorrectly believe that the block allocation bitmap overlaps with the
+block group descriptor blocks, and it would reject the mount.
+
+Fix both of these problems.
+
+Signed-off-by: Theodore Ts'o <tytso@mit.edu>
+Cc: stable@vger.kernel.org
+Signed-off-by: Benjamin Gilbert <bgilbert@redhat.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/ext4/super.c |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/fs/ext4/super.c
++++ b/fs/ext4/super.c
+@@ -2102,7 +2102,7 @@ static int ext4_check_descriptors(struct
+       struct ext4_sb_info *sbi = EXT4_SB(sb);
+       ext4_fsblk_t first_block = le32_to_cpu(sbi->s_es->s_first_data_block);
+       ext4_fsblk_t last_block;
+-      ext4_fsblk_t last_bg_block = sb_block + ext4_bg_num_gdb(sb, 0) + 1;
++      ext4_fsblk_t last_bg_block = sb_block + ext4_bg_num_gdb(sb, 0);
+       ext4_fsblk_t block_bitmap;
+       ext4_fsblk_t inode_bitmap;
+       ext4_fsblk_t inode_table;
+@@ -3777,13 +3777,13 @@ static int ext4_fill_super(struct super_
+                       goto failed_mount2;
+               }
+       }
++      sbi->s_gdb_count = db_count;
+       if (!ext4_check_descriptors(sb, logical_sb_block, &first_not_zeroed)) {
+               ext4_msg(sb, KERN_ERR, "group descriptors corrupted!");
+               ret = -EFSCORRUPTED;
+               goto failed_mount2;
+       }
+-      sbi->s_gdb_count = db_count;
+       get_random_bytes(&sbi->s_next_generation, sizeof(u32));
+       spin_lock_init(&sbi->s_next_gen_lock);
diff --git a/queue-4.4/i2c-imx-fix-reinit_completion-use.patch b/queue-4.4/i2c-imx-fix-reinit_completion-use.patch
new file mode 100644 (file)
index 0000000..c2b3faf
--- /dev/null
@@ -0,0 +1,53 @@
+From 9f9e3e0d4dd3338b3f3dde080789f71901e1e4ff Mon Sep 17 00:00:00 2001
+From: Esben Haabendal <eha@deif.com>
+Date: Mon, 9 Jul 2018 11:43:01 +0200
+Subject: i2c: imx: Fix reinit_completion() use
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Esben Haabendal <eha@deif.com>
+
+commit 9f9e3e0d4dd3338b3f3dde080789f71901e1e4ff upstream.
+
+Make sure to call reinit_completion() before dma is started to avoid race
+condition where reinit_completion() is called after complete() and before
+wait_for_completion_timeout().
+
+Signed-off-by: Esben Haabendal <eha@deif.com>
+Fixes: ce1a78840ff7 ("i2c: imx: add DMA support for freescale i2c driver")
+Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
+Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
+Cc: stable@kernel.org
+Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/i2c/busses/i2c-imx.c |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+--- a/drivers/i2c/busses/i2c-imx.c
++++ b/drivers/i2c/busses/i2c-imx.c
+@@ -382,6 +382,7 @@ static int i2c_imx_dma_xfer(struct imx_i
+               goto err_desc;
+       }
++      reinit_completion(&dma->cmd_complete);
+       txdesc->callback = i2c_imx_dma_callback;
+       txdesc->callback_param = i2c_imx;
+       if (dma_submit_error(dmaengine_submit(txdesc))) {
+@@ -631,7 +632,6 @@ static int i2c_imx_dma_write(struct imx_
+        * The first byte must be transmitted by the CPU.
+        */
+       imx_i2c_write_reg(msgs->addr << 1, i2c_imx, IMX_I2C_I2DR);
+-      reinit_completion(&i2c_imx->dma->cmd_complete);
+       time_left = wait_for_completion_timeout(
+                               &i2c_imx->dma->cmd_complete,
+                               msecs_to_jiffies(DMA_TIMEOUT));
+@@ -690,7 +690,6 @@ static int i2c_imx_dma_read(struct imx_i
+       if (result)
+               return result;
+-      reinit_completion(&i2c_imx->dma->cmd_complete);
+       time_left = wait_for_completion_timeout(
+                               &i2c_imx->dma->cmd_complete,
+                               msecs_to_jiffies(DMA_TIMEOUT));
diff --git a/queue-4.4/ring_buffer-tracing-inherit-the-tracing-setting-to-next-ring-buffer.patch b/queue-4.4/ring_buffer-tracing-inherit-the-tracing-setting-to-next-ring-buffer.patch
new file mode 100644 (file)
index 0000000..402a26b
--- /dev/null
@@ -0,0 +1,103 @@
+From 73c8d8945505acdcbae137c2e00a1232e0be709f Mon Sep 17 00:00:00 2001
+From: Masami Hiramatsu <mhiramat@kernel.org>
+Date: Sat, 14 Jul 2018 01:28:15 +0900
+Subject: ring_buffer: tracing: Inherit the tracing setting to next ring buffer
+
+From: Masami Hiramatsu <mhiramat@kernel.org>
+
+commit 73c8d8945505acdcbae137c2e00a1232e0be709f upstream.
+
+Maintain the tracing on/off setting of the ring_buffer when switching
+to the trace buffer snapshot.
+
+Taking a snapshot is done by swapping the backup ring buffer
+(max_tr_buffer). But since the tracing on/off setting is defined
+by the ring buffer, when swapping it, the tracing on/off setting
+can also be changed. This causes a strange result like below:
+
+  /sys/kernel/debug/tracing # cat tracing_on
+  1
+  /sys/kernel/debug/tracing # echo 0 > tracing_on
+  /sys/kernel/debug/tracing # cat tracing_on
+  0
+  /sys/kernel/debug/tracing # echo 1 > snapshot
+  /sys/kernel/debug/tracing # cat tracing_on
+  1
+  /sys/kernel/debug/tracing # echo 1 > snapshot
+  /sys/kernel/debug/tracing # cat tracing_on
+  0
+
+We don't touch tracing_on, but snapshot changes tracing_on
+setting each time. This is an anomaly, because user doesn't know
+that each "ring_buffer" stores its own tracing-enable state and
+the snapshot is done by swapping ring buffers.
+
+Link: http://lkml.kernel.org/r/153149929558.11274.11730609978254724394.stgit@devbox
+
+Cc: Ingo Molnar <mingo@redhat.com>
+Cc: Shuah Khan <shuah@kernel.org>
+Cc: Tom Zanussi <tom.zanussi@linux.intel.com>
+Cc: Hiraku Toyooka <hiraku.toyooka@cybertrust.co.jp>
+Cc: stable@vger.kernel.org
+Fixes: debdd57f5145 ("tracing: Make a snapshot feature available from userspace")
+Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
+[ Updated commit log and comment in the code ]
+Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
+Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ include/linux/ring_buffer.h |    1 +
+ kernel/trace/ring_buffer.c  |   16 ++++++++++++++++
+ kernel/trace/trace.c        |    6 ++++++
+ 3 files changed, 23 insertions(+)
+
+--- a/include/linux/ring_buffer.h
++++ b/include/linux/ring_buffer.h
+@@ -162,6 +162,7 @@ void ring_buffer_record_enable(struct ri
+ void ring_buffer_record_off(struct ring_buffer *buffer);
+ void ring_buffer_record_on(struct ring_buffer *buffer);
+ int ring_buffer_record_is_on(struct ring_buffer *buffer);
++int ring_buffer_record_is_set_on(struct ring_buffer *buffer);
+ void ring_buffer_record_disable_cpu(struct ring_buffer *buffer, int cpu);
+ void ring_buffer_record_enable_cpu(struct ring_buffer *buffer, int cpu);
+--- a/kernel/trace/ring_buffer.c
++++ b/kernel/trace/ring_buffer.c
+@@ -3142,6 +3142,22 @@ int ring_buffer_record_is_on(struct ring
+ }
+ /**
++ * ring_buffer_record_is_set_on - return true if the ring buffer is set writable
++ * @buffer: The ring buffer to see if write is set enabled
++ *
++ * Returns true if the ring buffer is set writable by ring_buffer_record_on().
++ * Note that this does NOT mean it is in a writable state.
++ *
++ * It may return true when the ring buffer has been disabled by
++ * ring_buffer_record_disable(), as that is a temporary disabling of
++ * the ring buffer.
++ */
++int ring_buffer_record_is_set_on(struct ring_buffer *buffer)
++{
++      return !(atomic_read(&buffer->record_disabled) & RB_BUFFER_OFF);
++}
++
++/**
+  * ring_buffer_record_disable_cpu - stop all writes into the cpu_buffer
+  * @buffer: The ring buffer to stop writes to.
+  * @cpu: The CPU buffer to stop
+--- a/kernel/trace/trace.c
++++ b/kernel/trace/trace.c
+@@ -1088,6 +1088,12 @@ update_max_tr(struct trace_array *tr, st
+       arch_spin_lock(&tr->max_lock);
++      /* Inherit the recordable setting from trace_buffer */
++      if (ring_buffer_record_is_set_on(tr->trace_buffer.buffer))
++              ring_buffer_record_on(tr->max_buffer.buffer);
++      else
++              ring_buffer_record_off(tr->max_buffer.buffer);
++
+       buf = tr->trace_buffer.buffer;
+       tr->trace_buffer.buffer = tr->max_buffer.buffer;
+       tr->max_buffer.buffer = buf;
index 9f026ed803417d259b700d8df7afcce4c97bf1e1..0362ed707e0c14f777150fdb02e1c5f9b2a3166a 100644 (file)
@@ -5,3 +5,7 @@ nohz-fix-local_timer_softirq_pending.patch
 netlink-do-not-subscribe-to-non-existent-groups.patch
 netlink-don-t-shift-with-ub-on-nlk-ngroups.patch
 netlink-don-t-shift-on-64-for-ngroups.patch
+ext4-fix-false-negatives-and-false-positives-in-ext4_check_descriptors.patch
+acpi-pci-bail-early-in-acpi_pci_add_bus-if-there-is-no-acpi-handle.patch
+ring_buffer-tracing-inherit-the-tracing-setting-to-next-ring-buffer.patch
+i2c-imx-fix-reinit_completion-use.patch