]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
netlink: specs: rtnetlink: correct notify properties
authorJakub Kicinski <kuba@kernel.org>
Fri, 18 Apr 2025 02:17:05 +0000 (19:17 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 23 Apr 2025 23:07:16 +0000 (16:07 -0700)
The notify property should point at the object the notifications
carry, usually the get object, not the cmd which triggers
the notification:

  notify:
    description: Name of the command sharing the reply type with
                 this notification.

Not treating this as a fix, I think that only C codegen cares.

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Link: https://patch.msgid.link/20250418021706.1967583-12-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Documentation/netlink/specs/rt-neigh.yaml
Documentation/netlink/specs/rt-rule.yaml

index fe34ade6b300bf8e50fee1be0628a03bf251806a..e9cba164e3d151737016582e2f57016673f50047 100644 (file)
@@ -381,7 +381,7 @@ operations:
       name: delneigh-ntf
       doc: Notify a neighbour deletion
       value: 29
-      notify: delneigh
+      notify: getneigh
       fixed-header: ndmsg
     -
       name: getneigh
index de0938d36541965ed28c22de28232c70d9528c63..f585654a4d410c596b442cf7c112bcc998fbbe10 100644 (file)
@@ -234,7 +234,7 @@ operations:
       name: newrule-ntf
       doc: Notify a rule creation
       value: 32
-      notify: newrule
+      notify: getrule
     -
       name: delrule
       doc: Remove an existing FIB rule
@@ -247,7 +247,7 @@ operations:
       name: delrule-ntf
       doc: Notify a rule deletion
       value: 33
-      notify: delrule
+      notify: getrule
     -
       name: getrule
       doc: Dump all FIB rules