]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: aacraid: Improve code readability
authorBart Van Assche <bvanassche@acm.org>
Tue, 21 Oct 2025 20:17:43 +0000 (13:17 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 24 Oct 2025 03:01:00 +0000 (23:01 -0400)
aac_queuecommand() is a scsi_host_template.queuecommand()
implementation.  Any value returned by this function other than one of
the following values is translated into SCSI_MLQUEUE_HOST_BUSY:

* 0
* SCSI_MLQUEUE_HOST_BUSY
* SCSI_MLQUEUE_DEVICE_BUSY
* SCSI_MLQUEUE_EH_RETRY
* SCSI_MLQUEUE_TARGET_BUSY

Improve readability of aac_queuecommand() by returning
SCSI_MLQUEUE_HOST_BUSY instead of FAILED.

Cc: Gilbert Wu <gilbert.wu@microchip.com>
Cc: Sagar Biradar <Sagar.Biradar@microchip.com>
Cc: John Garry <john.g.garry@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Link: https://patch.msgid.link/20251021201743.3539900-1-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aacraid/linit.c

index ea66196ef7c7e78843075b244f2538e5b9e8ec23..82c6e7c7cdaf9e247912c86da7aecafdd95fd4d6 100644 (file)
@@ -242,7 +242,7 @@ static int aac_queuecommand(struct Scsi_Host *shost,
 {
        aac_priv(cmd)->owner = AAC_OWNER_LOWLEVEL;
 
-       return aac_scsi_cmd(cmd) ? FAILED : 0;
+       return aac_scsi_cmd(cmd) ? SCSI_MLQUEUE_HOST_BUSY : 0;
 }
 
 /**