]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
padata: Clean up in padata_do_multithreaded()
authorZicheng Qu <quzicheng@huawei.com>
Fri, 1 Nov 2024 09:13:24 +0000 (09:13 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 10 Nov 2024 03:50:54 +0000 (11:50 +0800)
In commit 24cc57d8faaa ("padata: Honor the caller's alignment in case of
chunk_size 0"), the line 'ps.chunk_size = max(ps.chunk_size, 1ul)' was
added, making 'ps.chunk_size = 1U' redundant and never executed.

Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
kernel/padata.c

index d899f34558afcc1ca2ce9c13239c713f8d7b8f3f..d51bbc76b2279ca3ba51e5d0b0ea528bf0198374 100644 (file)
@@ -521,13 +521,6 @@ void __init padata_do_multithreaded(struct padata_mt_job *job)
        ps.chunk_size = max(ps.chunk_size, 1ul);
        ps.chunk_size = roundup(ps.chunk_size, job->align);
 
-       /*
-        * chunk_size can be 0 if the caller sets min_chunk to 0. So force it
-        * to at least 1 to prevent divide-by-0 panic in padata_mt_helper().`
-        */
-       if (!ps.chunk_size)
-               ps.chunk_size = 1U;
-
        list_for_each_entry(pw, &works, pw_list)
                if (job->numa_aware) {
                        int old_node = atomic_read(&last_used_nid);