rust/rust-compile-resolve-path.o \
rust/rust-macro-expand.o \
rust/rust-cfg-strip.o \
- rust/rust-expand-visitor.o \
- rust/rust-ast-builder.o \
- rust/rust-derive.o \
- rust/rust-derive-clone.o \
- rust/rust-derive-copy.o \
- rust/rust-proc-macro.o \
+ rust/rust-expand-visitor.o \
+ rust/rust-ast-builder.o \
+ rust/rust-derive.o \
+ rust/rust-derive-clone.o \
+ rust/rust-derive-copy.o \
+ rust/rust-proc-macro.o \
rust/rust-macro-invoc-lexer.o \
rust/rust-proc-macro-invoc-lexer.o \
rust/rust-macro-substitute-ctx.o \
rust/rust-attributes.o \
rust/rust-abi.o \
rust/rust-token-converter.o \
- rust/rust-macro.o \
+ rust/rust-macro.o \
rust/rust-ast-lower.o \
rust/rust-ast-lower-base.o \
rust/rust-ast-lower-pattern.o \
rust/rust-ast-lower-item.o \
rust/rust-ast-lower-expr.o \
rust/rust-ast-lower-type.o \
- rust/rust-ast-lower-stmt.o \
- rust/rust-rib.o \
- rust/rust-name-resolution-context.o \
- rust/rust-default-resolver.o \
+ rust/rust-ast-lower-stmt.o \
+ rust/rust-rib.o \
+ rust/rust-name-resolution-context.o \
+ rust/rust-default-resolver.o \
rust/rust-toplevel-name-resolver-2.0.o \
- rust/rust-early-name-resolver-2.0.o \
+ rust/rust-early-name-resolver-2.0.o \
rust/rust-early-name-resolver.o \
rust/rust-name-resolver.o \
rust/rust-ast-resolve.o \
rust/rust-const-checker.o \
rust/rust-lint-marklive.o \
rust/rust-lint-unused-var.o \
+ rust/rust-readonly-check.o \
rust/rust-hir-type-check-path.o \
rust/rust-unsafe-checker.o \
rust/rust-compile-intrinsic.o \
--- /dev/null
+// Copyright (C) 2021-2023 Free Software Foundation, Inc.
+
+// This file is part of GCC.
+
+// GCC is free software; you can redistribute it and/or modify it under
+// the terms of the GNU General Public License as published by the Free
+// Software Foundation; either version 3, or (at your option) any later
+// version.
+
+// GCC is distributed in the hope that it will be useful, but WITHOUT ANY
+// WARRANTY; without even the implied warranty of MERCHANTABILITY or
+// FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+// for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with GCC; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+#include "rust-readonly-check.h"
+#include "rust-tree.h"
+#include "rust-gcc.h"
+
+namespace Rust {
+namespace Analysis {
+
+// ported over from c-family/c-warn.cc
+void
+readonly_error (location_t loc, tree arg, enum lvalue_use use)
+{
+ gcc_assert (use == lv_assign || use == lv_increment || use == lv_decrement
+ || use == lv_asm);
+ STRIP_ANY_LOCATION_WRAPPER (arg);
+ /* Using this macro rather than (for example) arrays of messages
+ ensures that all the format strings are checked at compile
+ time. */
+#define READONLY_MSG(A, I, D, AS) \
+ (use == lv_assign \
+ ? (A) \
+ : (use == lv_increment ? (I) : (use == lv_decrement ? (D) : (AS))))
+ if (TREE_CODE (arg) == COMPONENT_REF)
+ {
+ if (TYPE_READONLY (TREE_TYPE (TREE_OPERAND (arg, 0))))
+ error_at (loc,
+ READONLY_MSG (G_ ("assignment of member "
+ "%qD in read-only object"),
+ G_ ("increment of member "
+ "%qD in read-only object"),
+ G_ ("decrement of member "
+ "%qD in read-only object"),
+ G_ ("member %qD in read-only object "
+ "used as %<asm%> output")),
+ TREE_OPERAND (arg, 1));
+ else
+ error_at (
+ loc,
+ READONLY_MSG (G_ ("assignment of read-only member %qD"),
+ G_ ("increment of read-only member %qD"),
+ G_ ("decrement of read-only member %qD"),
+ G_ ("read-only member %qD used as %<asm%> output")),
+ TREE_OPERAND (arg, 1));
+ }
+ else if (VAR_P (arg))
+ error_at (loc,
+ READONLY_MSG (G_ ("assignment of read-only variable %qD"),
+ G_ ("increment of read-only variable %qD"),
+ G_ ("decrement of read-only variable %qD"),
+ G_ (
+ "read-only variable %qD used as %<asm%> output")),
+ arg);
+ else if (TREE_CODE (arg) == PARM_DECL)
+ error_at (loc,
+ READONLY_MSG (G_ ("assignment of read-only parameter %qD"),
+ G_ ("increment of read-only parameter %qD"),
+ G_ ("decrement of read-only parameter %qD"),
+ G_ (
+ "read-only parameter %qD use as %<asm%> output")),
+ arg);
+ else if (TREE_CODE (arg) == RESULT_DECL)
+ {
+ error_at (loc,
+ READONLY_MSG (G_ ("assignment of "
+ "read-only named return value %qD"),
+ G_ ("increment of "
+ "read-only named return value %qD"),
+ G_ ("decrement of "
+ "read-only named return value %qD"),
+ G_ ("read-only named return value %qD "
+ "used as %<asm%>output")),
+ arg);
+ }
+ else if (TREE_CODE (arg) == FUNCTION_DECL)
+ error_at (loc,
+ READONLY_MSG (G_ ("assignment of function %qD"),
+ G_ ("increment of function %qD"),
+ G_ ("decrement of function %qD"),
+ G_ ("function %qD used as %<asm%> output")),
+ arg);
+ else
+ error_at (loc,
+ READONLY_MSG (G_ ("assignment of read-only location %qE"),
+ G_ ("increment of read-only location %qE"),
+ G_ ("decrement of read-only location %qE"),
+ G_ (
+ "read-only location %qE used as %<asm%> output")),
+ arg);
+}
+
+static void
+check_decl (tree *t)
+{
+ if (TREE_CODE (*t) == MODIFY_EXPR)
+ {
+ tree lhs = TREE_OPERAND (*t, 0);
+ if (TREE_READONLY (lhs) || TREE_CONSTANT (lhs))
+ {
+ readonly_error (EXPR_LOCATION (*t), lhs, lv_assign);
+ TREE_OPERAND (*t, 0) = error_mark_node;
+ }
+ }
+}
+
+static tree
+readonly_walk_fn (tree *t, int *, void *)
+{
+ switch (TREE_CODE (*t))
+ {
+ case MODIFY_EXPR:
+ check_decl (t);
+ break;
+
+ default:
+ break;
+ }
+ return NULL_TREE;
+}
+
+void
+ReadonlyCheck::Lint (Compile::Context &ctx)
+{
+ for (auto &fndecl : ctx.get_func_decls ())
+ {
+ for (tree p = DECL_ARGUMENTS (fndecl); p != NULL_TREE; p = DECL_CHAIN (p))
+ {
+ check_decl (&p);
+ }
+
+ walk_tree_without_duplicates (&DECL_SAVED_TREE (fndecl),
+ &readonly_walk_fn, &ctx);
+ }
+
+ for (auto &var : ctx.get_var_decls ())
+ {
+ tree decl = var->get_decl ();
+ check_decl (&decl);
+ }
+
+ for (auto &const_decl : ctx.get_const_decls ())
+ {
+ check_decl (&const_decl);
+ }
+}
+
+} // namespace Analysis
+} // namespace Rust
--- /dev/null
+// Copyright (C) 2021-2023 Free Software Foundation, Inc.
+
+// This file is part of GCC.
+
+// GCC is free software; you can redistribute it and/or modify it under
+// the terms of the GNU General Public License as published by the Free
+// Software Foundation; either version 3, or (at your option) any later
+// version.
+
+// GCC is distributed in the hope that it will be useful, but WITHOUT ANY
+// WARRANTY; without even the implied warranty of MERCHANTABILITY or
+// FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+// for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with GCC; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+#ifndef RUST_READONLY_CHECK
+#define RUST_READONLY_CHECK
+
+#include "rust-compile-context.h"
+
+namespace Rust {
+namespace Analysis {
+
+class ReadonlyCheck
+{
+public:
+ static void Lint (Compile::Context &ctx);
+};
+
+} // namespace Analysis
+} // namespace Rust
+
+#endif // RUST_READONLY_CHECK
#include "rust-ast-resolve-expr.h"
#include "rust-ast-resolve-stmt.h"
#include "rust-ast-resolve-struct-expr-field.h"
-#include "rust-ast-verify-assignee.h"
#include "rust-ast-resolve-type.h"
#include "rust-ast-resolve-pattern.h"
#include "rust-ast-resolve-path.h"
{
ResolveExpr::go (expr.get_left_expr ().get (), prefix, canonical_prefix);
ResolveExpr::go (expr.get_right_expr ().get (), prefix, canonical_prefix);
-
- // need to verify the assignee
- VerifyAsignee::go (expr.get_left_expr ().get ());
}
/* The "break rust" Easter egg.
{
ResolveExpr::go (expr.get_left_expr ().get (), prefix, canonical_prefix);
ResolveExpr::go (expr.get_right_expr ().get (), prefix, canonical_prefix);
-
- // need to verify the assignee
- VerifyAsignee::go (expr.get_left_expr ().get ());
}
void
+++ /dev/null
-// Copyright (C) 2020-2024 Free Software Foundation, Inc.
-
-// This file is part of GCC.
-
-// GCC is free software; you can redistribute it and/or modify it under
-// the terms of the GNU General Public License as published by the Free
-// Software Foundation; either version 3, or (at your option) any later
-// version.
-
-// GCC is distributed in the hope that it will be useful, but WITHOUT ANY
-// WARRANTY; without even the implied warranty of MERCHANTABILITY or
-// FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
-// for more details.
-
-// You should have received a copy of the GNU General Public License
-// along with GCC; see the file COPYING3. If not see
-// <http://www.gnu.org/licenses/>.
-
-#ifndef RUST_AST_VERIFY_ASSIGNEE
-#define RUST_AST_VERIFY_ASSIGNEE
-
-#include "rust-ast-resolve-base.h"
-#include "rust-ast-full.h"
-
-namespace Rust {
-namespace Resolver {
-
-class VerifyAsignee : public ResolverBase
-{
- using Rust::Resolver::ResolverBase::visit;
-
-public:
- static bool go (AST::Expr *assignee)
- {
- VerifyAsignee checker;
- assignee->accept_vis (checker);
- if (!checker.ok)
- rust_error_at (assignee->get_locus (), ErrorCode::E0070,
- "invalid left-hand side of assignment");
- return checker.ok;
- }
-
- void visit (AST::ArrayIndexExpr &expr) override
- {
- expr.get_array_expr ()->accept_vis (*this);
- }
-
- void visit (AST::FieldAccessExpr &expr) override
- {
- expr.get_receiver_expr ()->accept_vis (*this);
- }
-
- void visit (AST::TupleIndexExpr &expr) override
- {
- expr.get_tuple_expr ()->accept_vis (*this);
- }
-
- void visit (AST::IdentifierExpr &expr) override
- {
- if (!resolver->get_name_scope ().lookup (
- CanonicalPath::new_seg (expr.get_node_id (), expr.as_string ()),
- &resolved_node))
- return;
-
- ok = true;
- }
-
- void visit (AST::DereferenceExpr &expr) override
- {
- expr.get_dereferenced_expr ()->accept_vis (*this);
- }
-
- void visit (AST::PathInExpression &) override { ok = true; }
-
-private:
- VerifyAsignee () : ResolverBase (), ok (false) {}
-
- bool ok;
-};
-
-} // namespace Resolver
-} // namespace Rust
-
-#endif // RUST_AST_VERIFY_ASSIGNEE
#include "rust-cfg-parser.h"
#include "rust-lint-scan-deadcode.h"
#include "rust-lint-unused-var.h"
+#include "rust-readonly-check.h"
#include "rust-hir-dump.h"
#include "rust-ast-dump.h"
-#include "rust-ast-collector.h"
#include "rust-export-metadata.h"
#include "rust-imports.h"
#include "rust-extern-crate.h"
#include "rust-unicode.h"
#include "rust-attribute-values.h"
-#include "diagnostic.h"
#include "input.h"
#include "selftest.h"
#include "tm.h"
// lints
Analysis::ScanDeadcode::Scan (hir);
Analysis::UnusedVariables::Lint (ctx);
+ Analysis::ReadonlyCheck::Lint (ctx);
// metadata
bool specified_emit_metadata
--- /dev/null
+#![allow(unused)]
+const SOME_CONST: i32 = 12;
+
+fn some_function() {
+ SOME_CONST = 15; // { dg-error "assignment of read-only location" }
+}
+
+fn main() {
+ some_function();
+}
fn foo() {
- 1 = 3; // { dg-error "invalid left-hand side of assignment" }
+ 1 = 3; // { dg-error "assignment of read-only location" }
}
fn main() {
foo();
-}
\ No newline at end of file
+}
projects / thirdparty / gcc.git / commitdiff
