]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: mt9t112: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:13 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:23 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/mt9t112.c

index 878dff9b75777380b41c6e229007d40bf93aeb9d..2d2c840fc00216a77730a816c9ee1e89f9cdcd1b 100644 (file)
@@ -1078,13 +1078,12 @@ static int mt9t112_probe(struct i2c_client *client)
 
        v4l2_i2c_subdev_init(&priv->subdev, client, &mt9t112_subdev_ops);
 
-       priv->clk = devm_clk_get(&client->dev, "extclk");
-       if (PTR_ERR(priv->clk) == -ENOENT) {
+       priv->clk = devm_v4l2_sensor_clk_get(&client->dev, "extclk");
+       if (PTR_ERR(priv->clk) == -ENOENT)
                priv->clk = NULL;
-       } else if (IS_ERR(priv->clk)) {
-               dev_err(&client->dev, "Unable to get clock \"extclk\"\n");
-               return PTR_ERR(priv->clk);
-       }
+       else if (IS_ERR(priv->clk))
+               return dev_err_probe(&client->dev, PTR_ERR(priv->clk),
+                                    "Unable to get clock \"extclk\"\n");
 
        priv->standby_gpio = devm_gpiod_get_optional(&client->dev, "standby",
                                                     GPIOD_OUT_HIGH);