]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm: adp: Remove unnecessary print function dev_err()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Wed, 5 Mar 2025 02:05:46 +0000 (10:05 +0800)
committerAlyssa Rosenzweig <alyssa@rosenzweig.io>
Wed, 5 Mar 2025 13:39:12 +0000 (08:39 -0500)
The print function dev_err() is redundant because platform_get_irq_byname()
already prints an error.

./drivers/gpu/drm/adp/adp_drv.c:470:2-9: line 470 is redundant because platform_get_irq() already prints an error.
./drivers/gpu/drm/adp/adp_drv.c:476:2-9: line 476 is redundant because platform_get_irq() already prints an error.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19211
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250305020546.96564-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
drivers/gpu/drm/adp/adp_drv.c

index 0a39abdc9238de9191b7108dc9b240faf238e9fe..0eeb9e5fab26638bb4ff0110567e51145b533b4e 100644 (file)
@@ -466,16 +466,12 @@ static int adp_parse_of(struct platform_device *pdev, struct adp_drv_private *ad
        }
 
        adp->be_irq = platform_get_irq_byname(pdev, "be");
-       if (adp->be_irq < 0) {
-               dev_err(dev, "failed to find be irq");
+       if (adp->be_irq < 0)
                return adp->be_irq;
-       }
 
        adp->fe_irq = platform_get_irq_byname(pdev, "fe");
-       if (adp->fe_irq < 0) {
-               dev_err(dev, "failed to find fe irq");
+       if (adp->fe_irq < 0)
                return adp->fe_irq;
-       }
 
        return 0;
 }