libkmod: Inline elf_get_strings_section

Its only caller can do the processing directly (kmod_elf_new).

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/196
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>

diff --git a/libkmod/libkmod-elf.c b/libkmod/libkmod-elf.c
index ade39c29112e186f3ed3a59f30a8ddb2458506e4..2fb215d7fbff243dc2c906a8d0d11c7ad2cf09ba 100644 (file)
--- a/libkmod/libkmod-elf.c
+++ b/libkmod/libkmod-elf.c
@@ -246,12 +246,6 @@ fail:
        return -EINVAL;
 }
 
-static const char *elf_get_strings_section(const struct kmod_elf *elf, uint64_t *size)
-{
-       *size = elf->header.strings.size;
-       return elf_get_mem(elf, elf->header.strings.offset);
-}
-
 struct kmod_elf *kmod_elf_new(const void *memory, off_t size)
 {
        struct kmod_elf *elf;
@@ -333,8 +327,8 @@ struct kmod_elf *kmod_elf_new(const void *memory, off_t size)
                ELFDBG(elf, "could not get strings section\n");
                goto invalid;
        } else {
-               uint64_t slen;
-               const char *s = elf_get_strings_section(elf, &slen);
+               uint64_t slen = elf->header.strings.size;
+               const char *s = elf_get_mem(elf, elf->header.strings.offset);
                if (slen == 0 || s[slen - 1] != '\0') {
                        ELFDBG(elf, "strings section does not end with \\0\n");
                        goto invalid;