]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
genirq/irqdesc: Decrease indentation level in __irq_get_desc_lock()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 16 Apr 2025 11:40:33 +0000 (14:40 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 5 May 2025 13:24:06 +0000 (15:24 +0200)
There is a conditional that covers all the code for the entire function.
Invert it and decrease indentation level. This also helps for further
changes to be clearer and tidier.

[ tglx: Removed line breaks ]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250416114122.2191820-2-andriy.shevchenko@linux.intel.com
kernel/irq/irqdesc.c

index 4bcc6ff81e39054517b857d45c4c068862d718c6..5b3aee255ec54948028025c17c65a1ce4450a5c5 100644 (file)
@@ -896,27 +896,27 @@ unsigned int irq_get_next_irq(unsigned int offset)
        return irq_find_at_or_after(offset);
 }
 
-struct irq_desc *
-__irq_get_desc_lock(unsigned int irq, unsigned long *flags, bool bus,
-                   unsigned int check)
+struct irq_desc *__irq_get_desc_lock(unsigned int irq, unsigned long *flags, bool bus,
+                                    unsigned int check)
 {
-       struct irq_desc *desc = irq_to_desc(irq);
+       struct irq_desc *desc;
 
-       if (desc) {
-               if (check & _IRQ_DESC_CHECK) {
-                       if ((check & _IRQ_DESC_PERCPU) &&
-                           !irq_settings_is_per_cpu_devid(desc))
-                               return NULL;
-
-                       if (!(check & _IRQ_DESC_PERCPU) &&
-                           irq_settings_is_per_cpu_devid(desc))
-                               return NULL;
-               }
+       desc = irq_to_desc(irq);
+       if (!desc)
+               return NULL;
+
+       if (check & _IRQ_DESC_CHECK) {
+               if ((check & _IRQ_DESC_PERCPU) && !irq_settings_is_per_cpu_devid(desc))
+                       return NULL;
 
-               if (bus)
-                       chip_bus_lock(desc);
-               raw_spin_lock_irqsave(&desc->lock, *flags);
+               if (!(check & _IRQ_DESC_PERCPU) && irq_settings_is_per_cpu_devid(desc))
+                       return NULL;
        }
+
+       if (bus)
+               chip_bus_lock(desc);
+       raw_spin_lock_irqsave(&desc->lock, *flags);
+
        return desc;
 }