pg_regress: Disable autoruns for cmd.exe on Windows

This is similar to 9886744a361b, to prevent the execution of other
programs due to autorun configurations which could influence the
postmaster startup.

This was originally applied on HEAD as of 83c75ac7fb69 without a
backpatch, but the patch has survived CI and buildfarm cycles.  I have
checked that cmd /d exists down to Windows XP, which should make this
change work correctly in the oldest branches still supported.

Discussion: https://postgr.es/m/20230922.161551.320043332510268554.horikyota.ntt@gmail.com
Backpatch-through: 12

diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
index 627a5b44b48d6c60dbb9de217f56b7afe0333c35..91f0d08ea0a8bb66e4b60c33418f7dd117e51f95 100644 (file)
--- a/src/test/regress/pg_regress.c
+++ b/src/test/regress/pg_regress.c
@@ -1211,7 +1211,7 @@ spawn_process(const char *cmdline)
        HANDLE          restrictedToken;
 
        memset(&pi, 0, sizeof(pi));
-       cmdline2 = psprintf("cmd /c \"%s\"", cmdline);
+       cmdline2 = psprintf("cmd /d /c \"%s\"", cmdline);
 
        if ((restrictedToken =
                 CreateRestrictedProcess(cmdline2, &pi)) == 0)