]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: pistachio: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 24 Apr 2025 08:35:34 +0000 (10:35 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 29 Apr 2025 08:34:46 +0000 (10:34 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/20250424-gpiochip-set-rv-pinctrl-part2-v1-11-504f91120b99@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-pistachio.c

index 8c50e0091b32a931a121c22607b573f85112e21f..e7bf609609617d6af2f10a3df56c62e3bfe2dcd3 100644 (file)
@@ -1186,12 +1186,14 @@ static int pistachio_gpio_get(struct gpio_chip *chip, unsigned offset)
        return !!(gpio_readl(bank, reg) & BIT(offset));
 }
 
-static void pistachio_gpio_set(struct gpio_chip *chip, unsigned offset,
-                              int value)
+static int pistachio_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                             int value)
 {
        struct pistachio_gpio_bank *bank = gpiochip_get_data(chip);
 
        gpio_mask_writel(bank, GPIO_OUTPUT, offset, !!value);
+
+       return 0;
 }
 
 static int pistachio_gpio_direction_input(struct gpio_chip *chip,
@@ -1326,7 +1328,7 @@ static void pistachio_gpio_irq_handler(struct irq_desc *desc)
                        .direction_input = pistachio_gpio_direction_input, \
                        .direction_output = pistachio_gpio_direction_output, \
                        .get = pistachio_gpio_get,                      \
-                       .set = pistachio_gpio_set,                      \
+                       .set_rv = pistachio_gpio_set,                   \
                        .base = _pin_base,                              \
                        .ngpio = _npins,                                \
                },                                                      \