]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: meson: define the pull up/down resistor value as 60 kOhm
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sat, 29 Mar 2025 19:01:32 +0000 (20:01 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 15 Apr 2025 07:47:37 +0000 (09:47 +0200)
The public datasheets of the following Amlogic SoCs describe a typical
resistor value for the built-in pull up/down resistor:
- Meson8/8b/8m2: not documented
- GXBB (S905): 60 kOhm
- GXL (S905X): 60 kOhm
- GXM (S912): 60 kOhm
- G12B (S922X): 60 kOhm
- SM1 (S905D3): 60 kOhm

The public G12B and SM1 datasheets additionally state min and max
values:
- min value: 50 kOhm for both, pull-up and pull-down
- max value for the pull-up: 70 kOhm
- max value for the pull-down: 130 kOhm

Use 60 kOhm in the pinctrl-meson driver as well so it's shown in the
debugfs output. It may not be accurate for Meson8/8b/8m2 but in reality
60 kOhm is closer to the actual value than 1 Ohm.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/20250329190132.855196-1-martin.blumenstingl@googlemail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/meson/pinctrl-meson.c

index 253a0cc57e396dd9eb12fbc37bd6cf56801b5dc8..e5a32a0532eeecd420a09d0c565fdd9a69bc943c 100644 (file)
@@ -487,7 +487,7 @@ static int meson_pinconf_get(struct pinctrl_dev *pcdev, unsigned int pin,
        case PIN_CONFIG_BIAS_PULL_DOWN:
        case PIN_CONFIG_BIAS_PULL_UP:
                if (meson_pinconf_get_pull(pc, pin) == param)
-                       arg = 1;
+                       arg = 60000;
                else
                        return -EINVAL;
                break;