]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: qla2xxx: Fix error code in qla2x00_start_sp()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 26 Jun 2023 10:58:47 +0000 (13:58 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 6 Jul 2023 01:29:24 +0000 (21:29 -0400)
This should be negative -EAGAIN instead of positive.  The callers treat
non-zero error codes the same so it doesn't really impact runtime beyond
some trivial differences to debug output.

Fixes: 80676d054e5a ("scsi: qla2xxx: Fix session cleanup hang")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/49866d28-4cfe-47b0-842b-78f110e61aab@moroto.mountain
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_iocb.c

index 9c70c4e973ee115b12efff02e983c52a3335f115..730d8609276c6dd6657685a78d9f20c427bec8a3 100644 (file)
@@ -3912,7 +3912,7 @@ qla2x00_start_sp(srb_t *sp)
 
        pkt = __qla2x00_alloc_iocbs(sp->qpair, sp);
        if (!pkt) {
-               rval = EAGAIN;
+               rval = -EAGAIN;
                ql_log(ql_log_warn, vha, 0x700c,
                    "qla2x00_alloc_iocbs failed.\n");
                goto done;