]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
md/md-bitmap: remove the parameter 'init' for bitmap_ops->resize()
authorYu Kuai <yukuai3@huawei.com>
Mon, 7 Jul 2025 01:26:59 +0000 (09:26 +0800)
committerYu Kuai <yukuai3@huawei.com>
Sat, 6 Sep 2025 09:11:33 +0000 (17:11 +0800)
It's set to 'false' for all callers, hence it's useless and can be
removed.

Link: https://lore.kernel.org/linux-raid/20250707012711.376844-3-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Xiao Ni <xni@redhat.com>
drivers/md/dm-raid.c
drivers/md/md-bitmap.c
drivers/md/md-bitmap.h
drivers/md/md-cluster.c
drivers/md/raid1.c
drivers/md/raid10.c
drivers/md/raid5.c

index 79ea85d18e24e5a6b01773f190352c2b9bf76fdf..05811316dedde692c28ac2870475b8eb01794246 100644 (file)
@@ -4071,7 +4071,7 @@ static int raid_preresume(struct dm_target *ti)
                int chunksize = to_bytes(rs->requested_bitmap_chunk_sectors) ?: mddev->bitmap_info.chunksize;
 
                r = mddev->bitmap_ops->resize(mddev, mddev->dev_sectors,
-                                             chunksize, false);
+                                             chunksize);
                if (r)
                        DMERR("Failed to resize bitmap");
        }
index 334b71404930045d30e330a52429f1dee1fd5734..4b87a09589d5b2713ad263db2181ad12f1330748 100644 (file)
@@ -2593,15 +2593,14 @@ err:
        return ret;
 }
 
-static int bitmap_resize(struct mddev *mddev, sector_t blocks, int chunksize,
-                        bool init)
+static int bitmap_resize(struct mddev *mddev, sector_t blocks, int chunksize)
 {
        struct bitmap *bitmap = mddev->bitmap;
 
        if (!bitmap)
                return 0;
 
-       return __bitmap_resize(bitmap, blocks, chunksize, init);
+       return __bitmap_resize(bitmap, blocks, chunksize, false);
 }
 
 static ssize_t
index 59e9dd45cfdec51be1816722d8b35d1ed2dd1dae..28c1f1c1cc831d1db30143447a559f654b1913e7 100644 (file)
@@ -64,8 +64,7 @@ struct md_bitmap_stats {
 struct bitmap_operations {
        bool (*enabled)(struct mddev *mddev);
        int (*create)(struct mddev *mddev);
-       int (*resize)(struct mddev *mddev, sector_t blocks, int chunksize,
-                     bool init);
+       int (*resize)(struct mddev *mddev, sector_t blocks, int chunksize);
 
        int (*load)(struct mddev *mddev);
        void (*destroy)(struct mddev *mddev);
index 5497eaee96e7d31d5fee874a135a993f0ae79a03..6a7deb7e545b916c5492a592fc88707ec0f8238e 100644 (file)
@@ -630,7 +630,7 @@ static int process_recvd_msg(struct mddev *mddev, struct cluster_msg *msg)
                if (le64_to_cpu(msg->high) != mddev->pers->size(mddev, 0, 0))
                        ret = mddev->bitmap_ops->resize(mddev,
                                                        le64_to_cpu(msg->high),
-                                                       0, false);
+                                                       0);
                break;
        default:
                ret = -1;
index 408c263983215e0ae1ba9e96095e07d23988e3ec..ce24e3d01d4a1d5619bfca3c8bee0d0ad4204ead 100644 (file)
@@ -3330,7 +3330,7 @@ static int raid1_resize(struct mddev *mddev, sector_t sectors)
            mddev->array_sectors > newsize)
                return -EINVAL;
 
-       ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
+       ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
        if (ret)
                return ret;
 
index b60c30bfb6c794c9fb702724ea1b9cc62c1ec84b..269187faa011b92a2257a195883fbff805bf1f72 100644 (file)
@@ -4239,7 +4239,7 @@ static int raid10_resize(struct mddev *mddev, sector_t sectors)
            mddev->array_sectors > size)
                return -EINVAL;
 
-       ret = mddev->bitmap_ops->resize(mddev, size, 0, false);
+       ret = mddev->bitmap_ops->resize(mddev, size, 0);
        if (ret)
                return ret;
 
@@ -4508,7 +4508,7 @@ static int raid10_start_reshape(struct mddev *mddev)
                newsize = raid10_size(mddev, 0, conf->geo.raid_disks);
 
                if (!mddev_is_clustered(mddev)) {
-                       ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
+                       ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
                        if (ret)
                                goto abort;
                        else
@@ -4530,13 +4530,13 @@ static int raid10_start_reshape(struct mddev *mddev)
                            MD_FEATURE_RESHAPE_ACTIVE)) || (oldsize == newsize))
                        goto out;
 
-               ret = mddev->bitmap_ops->resize(mddev, newsize, 0, false);
+               ret = mddev->bitmap_ops->resize(mddev, newsize, 0);
                if (ret)
                        goto abort;
 
                ret = mddev->cluster_ops->resize_bitmaps(mddev, newsize, oldsize);
                if (ret) {
-                       mddev->bitmap_ops->resize(mddev, oldsize, 0, false);
+                       mddev->bitmap_ops->resize(mddev, oldsize, 0);
                        goto abort;
                }
        }
index 023649fe2476f3777f12c5e1793bc34e3703add5..bb95069e31f3f5a85062d44788cf2b6b00f05f46 100644 (file)
@@ -8322,7 +8322,7 @@ static int raid5_resize(struct mddev *mddev, sector_t sectors)
            mddev->array_sectors > newsize)
                return -EINVAL;
 
-       ret = mddev->bitmap_ops->resize(mddev, sectors, 0, false);
+       ret = mddev->bitmap_ops->resize(mddev, sectors, 0);
        if (ret)
                return ret;