]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i2c: qcom-geni: Keep comment why interrupts start disabled
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 1 Oct 2024 13:36:20 +0000 (15:36 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 17 Nov 2024 10:58:14 +0000 (11:58 +0100)
The to-be-fixed commit rightfully reduced a race window, but also
removed a comment which is still helpful after the fix. Bring the
comment back.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-qcom-geni.c

index 59f2e055d843814244f084cf0d254fe7144c6e3a..7a22e1f46e60a54bd335601ba82447c4f92f5156 100644 (file)
@@ -833,6 +833,8 @@ static int geni_i2c_probe(struct platform_device *pdev)
        init_completion(&gi2c->done);
        spin_lock_init(&gi2c->lock);
        platform_set_drvdata(pdev, gi2c);
+
+       /* Keep interrupts disabled initially to allow for low-power modes */
        ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN,
                               dev_name(dev), gi2c);
        if (ret) {