Process review comments

diff --git a/pdns/recursordist/docs/metrics.rst b/pdns/recursordist/docs/metrics.rst
index 9247a9955ca600aacd05dda1489ab934d33f9388..3700652d9c41ec0edc07b940bf93d10d456f9851 100644 (file)
--- a/pdns/recursordist/docs/metrics.rst
+++ b/pdns/recursordist/docs/metrics.rst
@@ -552,12 +552,12 @@ no-packet-error
 number of erroneous received packets
 
 nod-events
-^^^^^^^^^
+^^^^^^^^^^
 .. versionadded:: 4.9.0
 Count of NOD events
 
 udr-events
-^^^^^^^^^
+^^^^^^^^^^
 .. versionadded:: 4.9.0
 Count of UDR events
 

diff --git a/regression-tests.recursor-dnssec/test_SNMP.py b/regression-tests.recursor-dnssec/test_SNMP.py
index 9a04090ebdedf38cbe98b08b116aa1597c0ba03e..4ad78640cbcc442e8edabbb80d79e3d70c98533b 100644 (file)
--- a/regression-tests.recursor-dnssec/test_SNMP.py
+++ b/regression-tests.recursor-dnssec/test_SNMP.py
@@ -21,11 +21,15 @@ class TestSNMP(RecursorTest):
     """
 
     def _checkStatsValues(self, results):
-        for i in list(range(1, 148)):
+        count = 148
+        for i in list(range(1, count)):
             oid = self._snmpOID + '.1.' + str(i) + '.0'
             self.assertTrue(oid in results)
             self.assertTrue(isinstance(results[oid], Counter64))
 
+        oid = self._snmpOID + '.1.' + str(count + 1) + '.0'
+        self.assertFalse(oid in results)
+
         # check uptime > 0
         self.assertGreater(results['1.3.6.1.4.1.43315.2.1.75.0'], 0)
         # check memory usage > 0