run-command: mark unused async callback parameters

The start_async(), etc, functions need a "proc" callback that conforms
to a particular interface. Not every callback needs every parameter
(e.g., the caller might not even ask to open an input descriptor, in
which case there is no point in the callback looking at it). Let's mark
these for -Wunused-parameter.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index afd36c9c5344bfedec2fb158cf9f191adb7665a3..6882d526e67d8d1ad997646598d37b55b5f8acd2 100644 (file)
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -465,7 +465,7 @@ static void rp_error(const char *err, ...)
        va_end(params);
 }
 
-static int copy_to_sideband(int in, int out, void *arg)
+static int copy_to_sideband(int in, int UNUSED(out), void *UNUSED(arg))
 {
        char data[128];
        int keepalive_active = 0;

diff --git a/convert.c b/convert.c
index b31a25b536041becdfce19e9b7d2f9673f86c8ef..25d89fa83ba43441804eeaac6026a348bb0c4f7a 100644 (file)
--- a/convert.c
+++ b/convert.c
@@ -619,7 +619,7 @@ struct filter_params {
        const char *path;
 };
 
-static int filter_buffer_or_fd(int in, int out, void *data)
+static int filter_buffer_or_fd(int UNUSED(in), int out, void *data)
 {
        /*
         * Spawn cmd and feed the buffer contents through its stdin.

diff --git a/fetch-pack.c b/fetch-pack.c
index bda9d0f43309b445d4d95a48b4a7f438fc8670d3..9f2933e868a8dbd9156e2ad01776dbbffdb61425 100644 (file)
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -823,7 +823,7 @@ static int everything_local(struct fetch_pack_args *args,
        return retval;
 }
 
-static int sideband_demux(int in, int out, void *data)
+static int sideband_demux(int UNUSED(in), int out, void *data)
 {
        int *xd = data;
        int ret;

diff --git a/send-pack.c b/send-pack.c
index 662f7c2aeb9be883870b921bf71ab82c5ca431fc..7e99c64e6b8f68567febfccfb9cf39119b193b72 100644 (file)
--- a/send-pack.c
+++ b/send-pack.c
@@ -266,7 +266,7 @@ static int receive_status(struct packet_reader *reader, struct ref *refs)
        return ret;
 }
 
-static int sideband_demux(int in, int out, void *data)
+static int sideband_demux(int UNUSED(in), int out, void *data)
 {
        int *fd = data, ret;
        if (async_with_fork())