]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/tests: Fix a test in drm_test_check_valid_clones()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 12 Feb 2025 15:24:09 +0000 (18:24 +0300)
committerMaxime Ripard <mripard@kernel.org>
Thu, 13 Feb 2025 08:48:15 +0000 (09:48 +0100)
The drm_atomic_get_crtc_state() function returns error pointers and not
NULL.  Update the check to check for error pointers as well as NULL.

Fixes: 88849f24e2ab ("drm/tests: Add test for drm_atomic_helper_check_modeset()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/c50f11c7-932c-47dc-b40f-4ada8b9b6679@stanley.mountain
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/tests/drm_atomic_state_test.c

index 0ab5d9ec4a7503d0a96cd21d40817c35fdbcea24..5945c3298901147f2837b8033141e24f0a2d9659 100644 (file)
@@ -283,7 +283,7 @@ static void drm_test_check_valid_clones(struct kunit *test)
        KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
 
        crtc_state = drm_atomic_get_crtc_state(state, priv->crtc);
-       KUNIT_ASSERT_NOT_NULL(test, crtc_state);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state);
 
        crtc_state->encoder_mask = param->encoder_mask;