]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rocker: fix link status detection in rocker_carrier_init()
authorDmitry Antipov <dmantipov@yandex.ru>
Thu, 14 Nov 2024 15:19:46 +0000 (18:19 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 19 Nov 2024 02:39:21 +0000 (18:39 -0800)
Since '1 << rocker_port->pport' may be undefined for port >= 32,
cast the left operand to 'unsigned long long' like it's done in
'rocker_port_set_enable()' above. Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Link: https://patch.msgid.link/20241114151946.519047-1-dmantipov@yandex.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/rocker/rocker_main.c

index 84fa911c78db55d9dd2fd1f93a56440fcc373bec..fe0bf1d3217af2b4d3711adebc3b10b236e001bf 100644 (file)
@@ -2502,7 +2502,7 @@ static void rocker_carrier_init(const struct rocker_port *rocker_port)
        u64 link_status = rocker_read64(rocker, PORT_PHYS_LINK_STATUS);
        bool link_up;
 
-       link_up = link_status & (1 << rocker_port->pport);
+       link_up = link_status & (1ULL << rocker_port->pport);
        if (link_up)
                netif_carrier_on(rocker_port->dev);
        else