]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_create.c: fix Coverity CID#32400 Buffer not null terminated
authorMarek Schimara <Marek.Schimara@bull.net>
Wed, 15 Jun 2016 14:30:32 +0000 (16:30 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:33 +0000 (16:32 +0200)
        CWE-170 / https://cwe.mitre.org/data/definitions/170.html

src/rrd_create.c

index 531b85c35332a2adeb343f541895005f4ee5aea4..e29beddb469dce05719f01bfec70fa064ad09170 100644 (file)
@@ -381,11 +381,11 @@ int parseDS(const char *def,
     case DST_DERIVE:
     case DST_DCOUNTER:
     case DST_DDERIVE:
-        strncpy(ds_def->dst, dst_tmp, DST_SIZE);
+        strncpy(ds_def->dst, dst_tmp, DST_SIZE - 1);
        parseGENERIC_DS(dst_args, ds_def);
        break;
     case DST_CDEF:
-       strncpy(ds_def->dst, dst_tmp, DST_SIZE);
+       strncpy(ds_def->dst, dst_tmp, DST_SIZE - 1);
         parseCDEF_DS(dst_args, ds_def, key_hash, lookup);
        break;
     default: