]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: capabilities: Retire QEMU_CAPS_SNAPSHOT_INTERNAL_QMP
authorPeter Krempa <pkrempa@redhat.com>
Wed, 2 Apr 2025 07:59:48 +0000 (09:59 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 2 Apr 2025 14:51:41 +0000 (16:51 +0200)
The code now always assumes support for the QMP internal snapshot
commands so the capability is no longer needed.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
31 files changed:
src/qemu/qemu_capabilities.c
src/qemu/qemu_capabilities.h
tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml
tests/qemucapabilitiesdata/caps_10.0.0_x86_64+amdsev.xml
tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml
tests/qemucapabilitiesdata/caps_6.2.0_ppc64.xml
tests/qemucapabilitiesdata/caps_6.2.0_x86_64.xml
tests/qemucapabilitiesdata/caps_7.0.0_ppc64.xml
tests/qemucapabilitiesdata/caps_7.0.0_x86_64.xml
tests/qemucapabilitiesdata/caps_7.1.0_ppc64.xml
tests/qemucapabilitiesdata/caps_7.1.0_x86_64.xml
tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml
tests/qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml
tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml
tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml
tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml
tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml
tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml
tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml
tests/qemucapabilitiesdata/caps_8.2.0_loongarch64.xml
tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml
tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml
tests/qemucapabilitiesdata/caps_9.0.0_sparc.xml
tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml
tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml
tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml
tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml
tests/qemucapabilitiesdata/caps_9.2.0_aarch64+hvf.xml
tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml
tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml
tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml

index 67350f230009b0072a86457ed453a87e14945109..665f5e225ebf5456ac2328fd0ceec4a2c2533888 100644 (file)
@@ -717,7 +717,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
               "machine-i8042-opt", /* QEMU_CAPS_MACHINE_I8042_OPT */
 
               /* 465 */
-              "snapshot-internal-qmp", /* QEMU_CAPS_SNAPSHOT_INTERNAL_QMP */
+              "snapshot-internal-qmp", /* X_QEMU_CAPS_SNAPSHOT_INTERNAL_QMP */
               "chardev-reconnect-miliseconds", /* QEMU_CAPS_CHARDEV_RECONNECT_MILISECONDS */
               "virtio-ccw.loadparm", /* QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM */
               "netdev-stream-reconnect-miliseconds", /* QEMU_CAPS_NETDEV_STREAM_RECONNECT_MILISECONDS */
@@ -1251,7 +1251,6 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
     { "query-stats", QEMU_CAPS_QUERY_STATS },
     { "query-stats-schemas", QEMU_CAPS_QUERY_STATS_SCHEMAS },
     { "display-reload", QEMU_CAPS_DISPLAY_RELOAD },
-    { "snapshot-save", QEMU_CAPS_SNAPSHOT_INTERNAL_QMP },
     { "blockdev-set-active", QEMU_CAPS_BLOCKDEV_SET_ACTIVE },
 };
 
index 2c2433580c152f0b6401000d45f98082202c476a..685a938bbc630e48c4653bb5d122c3e613b599cf 100644 (file)
@@ -698,7 +698,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
     QEMU_CAPS_MACHINE_I8042_OPT, /* -machine xxx,i8042=on/off; use virQEMUCapsSupportsI8042Toggle() to query this capability */
 
     /* 465 */
-    QEMU_CAPS_SNAPSHOT_INTERNAL_QMP, /* internal snapshot support via QMP commands 'snapshot-save'/'snapshot-delete' */
+    X_QEMU_CAPS_SNAPSHOT_INTERNAL_QMP, /* internal snapshot support via QMP commands 'snapshot-save'/'snapshot-delete' */
     QEMU_CAPS_CHARDEV_RECONNECT_MILISECONDS, /* 'reconnect-ms' option for chardevs supported */
     QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM, /* loadparm available on CCW device for multi device boot */
     QEMU_CAPS_NETDEV_STREAM_RECONNECT_MILISECONDS, /* 'reconnect-ms' option for netdev stream supported */
index 0600cbda62878f3a5368eadc3e10d5ba518dba4b..4f3669ebb7dc1fd8931af024601d208629c05af4 100644 (file)
   <flag name='usb-mtp'/>
   <flag name='virtio-sound'/>
   <flag name='netdev.user'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='chardev-reconnect-miliseconds'/>
   <flag name='virtio-ccw.loadparm'/>
   <flag name='netdev-stream-reconnect-miliseconds'/>
index ad7bb7ebc8adb35f4d670f92a2191f9bd524fe88..eaf35bb7033a8b0d336f139ca65d88cf4acfa9cc 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='chardev-reconnect-miliseconds'/>
   <flag name='netdev-stream-reconnect-miliseconds'/>
   <flag name='migrate-incoming.exit-on-error'/>
index 529ec7fbe2d84cbca68418d811d7c4bc699abbbf..dea2e3fc893043b24112057b462a5ef41bfb5eab 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='chardev-reconnect-miliseconds'/>
   <flag name='netdev-stream-reconnect-miliseconds'/>
   <flag name='migrate-incoming.exit-on-error'/>
index e080352a4c7c16fff1b7b9c5b1f6e0e3c5a07715..cf5fc6b01751b97031b226c35382d77b9b424d89 100644 (file)
   <flag name='display-reload'/>
   <flag name='usb-mtp'/>
   <flag name='netdev.user'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>6002000</version>
   <microcodeVersion>42900244</microcodeVersion>
   <package>v6.2.0</package>
index 1c7def169c091742cdeb75ff05142ce6449d9fa9..ed43c4767f9ee7011de67b5ca687de5acabded7a 100644 (file)
   <flag name='display-reload'/>
   <flag name='usb-mtp'/>
   <flag name='netdev.user'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>6002000</version>
   <microcodeVersion>43100244</microcodeVersion>
   <package>v6.2.0</package>
index a5dbf4fb133975a058b29bfe491b84bb2cb79ec4..9a273e531e626b5be5e652a63e9b9e7c23649e0d 100644 (file)
   <flag name='usb-mtp'/>
   <flag name='netdev.user'/>
   <flag name='acpi-erst'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>7000000</version>
   <microcodeVersion>42900243</microcodeVersion>
   <package>v7.0.0</package>
index 8e342bf4adec1f15e81cc5898159875b398a7faa..3214f50be64a32b477c912fe01dcdf211ee94615 100644 (file)
   <flag name='netdev.user'/>
   <flag name='acpi-erst'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>7000000</version>
   <microcodeVersion>43100243</microcodeVersion>
   <package>v7.0.0</package>
index 610ca193d05978e5b83276f96ebbf2264d1e1b13..46a93cadbcae6b6b7927703b8ed99d86a91f9e65 100644 (file)
   <flag name='usb-mtp'/>
   <flag name='netdev.user'/>
   <flag name='acpi-erst'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>7001000</version>
   <microcodeVersion>42900244</microcodeVersion>
   <package>v7.1.0</package>
index 71e6c16e8fe1e2ba1359bea47481738551f334af..eb5e35b904bcf64a76d604cff72f84e6d142aabb 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>7001000</version>
   <microcodeVersion>43100244</microcodeVersion>
   <package>v7.1.0</package>
index bba337648480a2a574d3ed81e30da0cda8042d67..f8b79cc7516be5530df2ca9e4d245825de6d0d44 100644 (file)
   <flag name='usb-mtp'/>
   <flag name='netdev.user'/>
   <flag name='acpi-erst'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>7002000</version>
   <microcodeVersion>0</microcodeVersion>
   <package>qemu-7.2.0-6.fc37</package>
index 7bdeb00f9a488d92328e2ebd8110717847bca562..6ea91329bc34aa893928fb600fdf5f526019e12e 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>7002000</version>
   <microcodeVersion>43100245</microcodeVersion>
   <package>v7.2.0</package>
index 54c72521b0693ce06ab043eb15a35eade63e5fdc..dfecf16eaf7c4e337ce3c4180eb505c6697c4bc5 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>7002000</version>
   <microcodeVersion>43100245</microcodeVersion>
   <package>v7.2.0</package>
index 54db96d9c79dd6233b5bf710a10a100a896c85c7..09c9fbe17e92bb9eb0a8c657426fdc86ddd346a4 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>8000000</version>
   <microcodeVersion>43100244</microcodeVersion>
   <package>v8.0.0</package>
index 0de066b2d980f3d83dc06fe54452f3ade15b7507..4127437fcc502206e553e476207ca3b309ed969d 100644 (file)
   <flag name='display-reload'/>
   <flag name='usb-mtp'/>
   <flag name='netdev.user'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>8001000</version>
   <microcodeVersion>39100245</microcodeVersion>
   <package>v8.1.0</package>
index 7d508a160144f8e08d1e5fc52f1e26a42618ea1e..eb03dd891a218f3ac30691e2ccc7b60105d00789 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>8001000</version>
   <microcodeVersion>43100245</microcodeVersion>
   <package>v8.1.0</package>
index 047a08a20c440b538334790a94baa1dc7969e161..31757fcc4f90da3f89470f559f1ef7b2f7e8bb5f 100644 (file)
   <flag name='virtio-sound'/>
   <flag name='netdev.user'/>
   <flag name='acpi-erst'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>8002000</version>
   <microcodeVersion>61700246</microcodeVersion>
   <package>v8.2.0</package>
index 3bf741931d07d42ec3770d25b1810821cf0b9bdc..af50e1acd2a76cd810a837b24eb17f483dbf68e0 100644 (file)
   <flag name='virtio-sound'/>
   <flag name='netdev.user'/>
   <flag name='acpi-erst'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>8002000</version>
   <microcodeVersion>0</microcodeVersion>
   <package>qemu-8.2.0-7.fc39</package>
index 73871a6880bb8d71fd3967115579e2495e8ed5da..067526a4f1c3a2294102f256c144ca0a6aa8b5fa 100644 (file)
   <flag name='virtio-sound'/>
   <flag name='netdev.user'/>
   <flag name='acpi-erst'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>8002000</version>
   <microcodeVersion>106300246</microcodeVersion>
   <package>v8.2.0</package>
index d1f4bd300e0287f4b6fedbb57ff1e3f31c69a3e4..9b0b5bdd9da104a202a2cfc6da9e066a39d34c22 100644 (file)
   <flag name='usb-mtp'/>
   <flag name='virtio-sound'/>
   <flag name='netdev.user'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>8002000</version>
   <microcodeVersion>39100246</microcodeVersion>
   <package>v8.2.0</package>
index 2da46d944dd9ff86314ae4f30103e0c4fdbb3bee..e786f16ec151c17e57fc812a1dc77f41e9bbfc00 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>8002000</version>
   <microcodeVersion>43100246</microcodeVersion>
   <package>v8.2.0</package>
index 698136134d38fe6ebb1d473e15d031424c10b2c6..74d10dc744a0ccee1d2dcc7ac8542893cf933b93 100644 (file)
@@ -72,7 +72,6 @@
   <flag name='blockjob.backing-mask-protocol'/>
   <flag name='display-reload'/>
   <flag name='netdev.user'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>9000000</version>
   <microcodeVersion>0</microcodeVersion>
   <package>qemu-9.0.0-1.fc40</package>
index b273193d3569303eb30acee55155940678c7d006..ec716821506950e3f9a27bab5be3cfb4e8d6f4b6 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <version>9000000</version>
   <microcodeVersion>43100245</microcodeVersion>
   <package>v9.0.0</package>
index 60eeb04fe744668a1fdd8df61535ee4625016857..2fa5d84c2475b47cfdae8f71244960088b4ff554 100644 (file)
   <flag name='virtio-sound'/>
   <flag name='netdev.user'/>
   <flag name='acpi-erst'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='migrate-incoming.exit-on-error'/>
   <flag name='machine.virt.aia'/>
   <version>9001000</version>
index 91738c02048b3eda2fd8018fb648956c2cd4affb..f2fb085af3c05bff20c5ddcc5d4c912fa1e25b28 100644 (file)
   <flag name='usb-mtp'/>
   <flag name='virtio-sound'/>
   <flag name='netdev.user'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='query-cpu-model-expansion.deprecated-props'/>
   <flag name='migrate-incoming.exit-on-error'/>
   <version>9001000</version>
index 6b995c2f26340733f93cb0e6e7379e839b93fbcc..08a4b24ae72e771e48cae5dd883f400ddb20520c 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='migrate-incoming.exit-on-error'/>
   <version>9001000</version>
   <microcodeVersion>43100246</microcodeVersion>
index a7bfc10168315b93f49228774d3c59139ba0e75d..7c9d245099e1e27f99bb339c6ebf751bfadcb138 100644 (file)
   <flag name='virtio-sound'/>
   <flag name='netdev.user'/>
   <flag name='acpi-erst'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='chardev-reconnect-miliseconds'/>
   <flag name='netdev-stream-reconnect-miliseconds'/>
   <flag name='migrate-incoming.exit-on-error'/>
index 7427bab1e9149c9101d0bc5c26ed623492a4cb9e..572e829208d5f09310d0f44bf4627466813a1351 100644 (file)
   <flag name='usb-mtp'/>
   <flag name='virtio-sound'/>
   <flag name='netdev.user'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='chardev-reconnect-miliseconds'/>
   <flag name='virtio-ccw.loadparm'/>
   <flag name='netdev-stream-reconnect-miliseconds'/>
index 2181b9432ae4653f766551dc6853476e92b36f26..be235051e25ca80afc440dcd386853a6eeeb32bf 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='chardev-reconnect-miliseconds'/>
   <flag name='netdev-stream-reconnect-miliseconds'/>
   <flag name='migrate-incoming.exit-on-error'/>
index 924f56d0103755144b36a8b8aae2cbc7bf857b18..73b2897c22998752f6e5275b60b4c7d62f351be3 100644 (file)
   <flag name='acpi-erst'/>
   <flag name='intel-iommu.dma-translation'/>
   <flag name='machine-i8042-opt'/>
-  <flag name='snapshot-internal-qmp'/>
   <flag name='chardev-reconnect-miliseconds'/>
   <flag name='netdev-stream-reconnect-miliseconds'/>
   <flag name='migrate-incoming.exit-on-error'/>