]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
analyze: actually select longest activated-time of services 9438/head
authorYu Watanabe <watanabe.yu+github@gmail.com>
Wed, 27 Jun 2018 04:32:05 +0000 (13:32 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Wed, 27 Jun 2018 05:54:19 +0000 (14:54 +0900)
Discovered by LGTM.

src/analyze/analyze.c

index de0fe6eba8113b90afb19a246ef8e29e8ba19e28..6ea4de1f293cfcda9e6d7e93e11d6aa511229556 100644 (file)
@@ -890,11 +890,8 @@ static int list_dependencies_one(sd_bus *bus, const char *name, unsigned int lev
         STRV_FOREACH(c, deps) {
                 times = hashmap_get(unit_times_hashmap, *c);
                 if (times_in_range(times, boot) &&
-                    (times->activated >= service_longest
-                     || service_longest == 0)) {
+                    times->activated >= service_longest)
                         service_longest = times->activated;
-                        break;
-                }
         }
 
         if (service_longest == 0)