drm/amdgpu: fix the warning bad bit shift operation for aca_error_type type

Filter invalid aca error types before performing a shift operation.

Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
Reviewed-by: Yang Wang <kevinyang.wang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
index 28febf33fb1bc3830b5ac3a72c3943c65cf9706d..9e3560c190e316d22564bf669ee9658a77a8af14 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
@@ -534,7 +534,7 @@ int amdgpu_aca_get_error_data(struct amdgpu_device *adev, struct aca_handle *han
        if (aca_handle_is_valid(handle))
                return -EOPNOTSUPP;
 
-       if (!(BIT(type) & handle->mask))
+       if ((type < 0) || (!(BIT(type) & handle->mask)))
                return  0;
 
        return __aca_get_error_data(adev, handle, type, err_data, qctx);