]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Input: ilitek_ts_i2c - use device core to create driver-specific device attributes
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 29 Jul 2023 00:51:23 +0000 (17:51 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 6 Sep 2023 21:29:02 +0000 (14:29 -0700)
Instead of creating driver-specific device attributes with
devm_device_add_group() have device core do this by setting up dev_groups
pointer in the driver structure.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20230729005133.1095051-14-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/ilitek_ts_i2c.c

index 2f872e95fbbadee2df4304c30120a04613bfada3..90c4934e750a3a3dda59e0688388f8d1f0dcf4b4 100644 (file)
@@ -537,10 +537,7 @@ static struct attribute *ilitek_sysfs_attrs[] = {
        &dev_attr_product_id.attr,
        NULL
 };
-
-static struct attribute_group ilitek_attrs_group = {
-       .attrs = ilitek_sysfs_attrs,
-};
+ATTRIBUTE_GROUPS(ilitek_sysfs);
 
 static int ilitek_ts_i2c_probe(struct i2c_client *client)
 {
@@ -595,12 +592,6 @@ static int ilitek_ts_i2c_probe(struct i2c_client *client)
                return error;
        }
 
-       error = devm_device_add_group(dev, &ilitek_attrs_group);
-       if (error) {
-               dev_err(dev, "sysfs create group failed: %d\n", error);
-               return error;
-       }
-
        return 0;
 }
 
@@ -675,6 +666,7 @@ MODULE_DEVICE_TABLE(of, ilitek_ts_i2c_match);
 static struct i2c_driver ilitek_ts_i2c_driver = {
        .driver = {
                .name = ILITEK_TS_NAME,
+               .dev_groups = ilitek_sysfs_groups,
                .pm = pm_sleep_ptr(&ilitek_pm_ops),
                .of_match_table = of_match_ptr(ilitek_ts_i2c_match),
                .acpi_match_table = ACPI_PTR(ilitekts_acpi_id),