]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
dmaengine: xilinx_dma: check dma_async_device_register return value
authorShravya Kumbham <shravya.kumbham@xilinx.com>
Wed, 23 Dec 2020 11:21:00 +0000 (16:51 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Jan 2021 13:05:36 +0000 (14:05 +0100)
commit 99974aedbd73523969afb09f33c6e3047cd0ddae upstream.

dma_async_device_register() can return non-zero error code. Add
condition to check the return value of dma_async_device_register
function and handle the error path.

Addresses-Coverity: Event check_return.
Fixes: 9cd4360de609 ("dma: Add Xilinx AXI Video Direct Memory Access Engine driver support")
Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Link: https://lore.kernel.org/r/1608722462-29519-2-git-send-email-radhey.shyam.pandey@xilinx.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/xilinx/xilinx_dma.c

index a6abfe702c5a31fc5cb01d9d9568d83fdf167fba..73cb2362322f4f014aaf6d545ff0df161ccf6384 100644 (file)
@@ -2742,7 +2742,11 @@ static int xilinx_dma_probe(struct platform_device *pdev)
        }
 
        /* Register the DMA engine with the core */
-       dma_async_device_register(&xdev->common);
+       err = dma_async_device_register(&xdev->common);
+       if (err) {
+               dev_err(xdev->dev, "failed to register the dma device\n");
+               goto error;
+       }
 
        err = of_dma_controller_register(node, of_dma_xilinx_xlate,
                                         xdev);