]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: anx7625: use eld_mutex to protect access to connector->eld
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fri, 6 Dec 2024 09:43:05 +0000 (11:43 +0200)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 16 Dec 2024 16:02:07 +0000 (18:02 +0200)
Reading access to connector->eld can happen at the same time the
drm_edid_to_eld() updates the data. Take the newly added eld_mutex in
order to protect connector->eld from concurrent access.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241206-drm-connector-eld-mutex-v2-2-c9bce1ee8bea@linaro.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/bridge/analogix/anx7625.c

index 3427322f986a6d3dfb5a3bc94000aeedac61e4cf..6238eabd23282d5f7e59a05d267737f40211aaf3 100644 (file)
@@ -2002,8 +2002,10 @@ static int anx7625_audio_get_eld(struct device *dev, void *data,
                memset(buf, 0, len);
        } else {
                dev_dbg(dev, "audio copy eld\n");
+               mutex_lock(&ctx->connector->eld_mutex);
                memcpy(buf, ctx->connector->eld,
                       min(sizeof(ctx->connector->eld), len));
+               mutex_unlock(&ctx->connector->eld_mutex);
        }
 
        return 0;