wifi: rtlwifi: do not complete firmware loading needlessly

The only code waiting for completion is driver removal, which will not be
called when probe returns a failure. So this completion is unnecessary.

Fixes: b0302aba812b ("rtlwifi: Convert to asynchronous firmware load")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20241107133322.855112-2-cascardo@igalia.com

diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c
index 11709b6c83f1aa7ad107b36c9ace9be308b47c36..40fc3c297a8ac4a5e37b8da9e4f5c2ae086731b0 100644 (file)
--- a/drivers/net/wireless/realtek/rtlwifi/pci.c
+++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
@@ -2266,7 +2266,6 @@ fail2:
                pci_iounmap(pdev, (void __iomem *)rtlpriv->io.pci_mem_start);
 
        pci_release_regions(pdev);
-       complete(&rtlpriv->firmware_loading_complete);
 
 fail1:
        if (hw)

diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
index d37a017b2b814f83a0cc1689abb8a2ecaba8f509..c3aa0cd9ff2117caed8698b91bd5c7c41aa421d4 100644 (file)
--- a/drivers/net/wireless/realtek/rtlwifi/usb.c
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
@@ -1040,7 +1040,6 @@ error_out:
 error_out2:
        _rtl_usb_io_handler_release(hw);
        usb_put_dev(udev);
-       complete(&rtlpriv->firmware_loading_complete);
        kfree(rtlpriv->usb_data);
        ieee80211_free_hw(hw);
        return -ENODEV;