]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
fs-posix: Replace fs_set_critical() with e_error()
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Mon, 25 Nov 2019 11:19:55 +0000 (13:19 +0200)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Wed, 11 Dec 2019 10:12:30 +0000 (10:12 +0000)
fs_set_error() can't be used in fs_file_close() and fs_file_deinit(),
because they don't return an error.

src/lib-fs/fs-posix.c

index f9437f3b7c0989f26558ee9150e55bde031f4b69..ae4cdca4cdaa8e0bb4ed385691e57b98585d12e9 100644 (file)
@@ -353,8 +353,8 @@ static void fs_posix_file_close(struct fs_file *_file)
 
        if (file->fd != -1 && file->file.output == NULL) {
                if (close(file->fd) < 0) {
-                       fs_set_critical(file->file.fs, "close(%s) failed: %m",
-                                       file->full_path);
+                       e_error(_file->event, "close(%s) failed: %m",
+                               file->full_path);
                }
                file->fd = -1;
        }
@@ -378,8 +378,8 @@ static void fs_posix_file_deinit(struct fs_file *_file)
                        break;
                /* failed to create/replace this. delete the temp file */
                if (unlink(file->temp_path) < 0) {
-                       fs_set_critical(_file->fs, "unlink(%s) failed: %m",
-                                       file->temp_path);
+                       e_error(_file->event, "unlink(%s) failed: %m",
+                               file->temp_path);
                }
                break;
        }