]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
IB/qib: Remove unused cnt variable
authorTom Rix <trix@redhat.com>
Thu, 30 Mar 2023 23:58:00 +0000 (19:58 -0400)
committerLeon Romanovsky <leon@kernel.org>
Mon, 3 Apr 2023 12:46:53 +0000 (15:46 +0300)
clang with W=1 reports
drivers/infiniband/hw/qib/qib_file_ops.c:487:20: error: variable
  'cnt' set but not used [-Werror,-Wunused-but-set-variable]
        u32 tid, ctxttid, cnt, limit, tidcnt;
                          ^
drivers/infiniband/hw/qib/qib_file_ops.c:1771:9: error: variable
  'cnt' set but not used [-Werror,-Wunused-but-set-variable]
        int i, cnt = 0, maxtid = ctxt_tidbase + dd->rcvtidcnt;
               ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20230330235800.1845815-1-trix@redhat.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/qib/qib_file_ops.c

index 80fe92a21f960e341eb85e3c27b6fb2ae89d66cd..076098803f5254a2253e241137fb2c023f0cf96a 100644 (file)
@@ -484,7 +484,7 @@ static int qib_tid_free(struct qib_ctxtdata *rcd, unsigned subctxt,
                        const struct qib_tid_info *ti)
 {
        int ret = 0;
-       u32 tid, ctxttid, cnt, limit, tidcnt;
+       u32 tid, ctxttid, limit, tidcnt;
        struct qib_devdata *dd = rcd->dd;
        u64 __iomem *tidbase;
        unsigned long tidmap[8];
@@ -520,7 +520,7 @@ static int qib_tid_free(struct qib_ctxtdata *rcd, unsigned subctxt,
                /* just in case size changes in future */
                limit = tidcnt;
        tid = find_first_bit(tidmap, limit);
-       for (cnt = 0; tid < limit; tid++) {
+       for (; tid < limit; tid++) {
                /*
                 * small optimization; if we detect a run of 3 or so without
                 * any set, use find_first_bit again.  That's mainly to
@@ -530,7 +530,7 @@ static int qib_tid_free(struct qib_ctxtdata *rcd, unsigned subctxt,
                 */
                if (!test_bit(tid, tidmap))
                        continue;
-               cnt++;
+
                if (dd->pageshadow[ctxttid + tid]) {
                        struct page *p;
                        dma_addr_t phys;
@@ -1768,7 +1768,7 @@ static void unlock_expected_tids(struct qib_ctxtdata *rcd)
 {
        struct qib_devdata *dd = rcd->dd;
        int ctxt_tidbase = rcd->ctxt * dd->rcvtidcnt;
-       int i, cnt = 0, maxtid = ctxt_tidbase + dd->rcvtidcnt;
+       int i, maxtid = ctxt_tidbase + dd->rcvtidcnt;
 
        for (i = ctxt_tidbase; i < maxtid; i++) {
                struct page *p = dd->pageshadow[i];
@@ -1783,7 +1783,6 @@ static void unlock_expected_tids(struct qib_ctxtdata *rcd)
                dma_unmap_page(&dd->pcidev->dev, phys, PAGE_SIZE,
                               DMA_FROM_DEVICE);
                qib_release_user_pages(&p, 1);
-               cnt++;
        }
 }