- (djm) Avoid redundant xstrdup/xfree in auth2-pam.c. From Solar via markus@

diff --git a/ChangeLog b/ChangeLog
index 0e00a6c9cdb801035a8ac3c8a0a2dd3e5356bf21..fae787ac079710a9332c2e90054b597f629052f1 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,6 @@
 20030108
  - (djm) Sync openbsd-compat/ with OpenBSD -current
+ - (djm) Avoid redundant xstrdup/xfree in auth2-pam.c. From Solar via markus@
 
 20030107
  - (djm) Bug #401: Work around Linux breakage with IPv6 mapped addresses. 
@@ -945,4 +946,4 @@
      save auth method before monitor_reset_key_state(); bugzilla bug #284;
      ok provos@
 
-$Id: ChangeLog,v 1.2549 2003/01/08 00:16:48 djm Exp $
+$Id: ChangeLog,v 1.2550 2003/01/08 01:37:03 djm Exp $

diff --git a/auth2-pam.c b/auth2-pam.c
index a2daf96b71aaeaa6c5f6bf86b57b56ee305e6e93..ac28fb2451c9dea6e3250d87c97965c8522d33fe 100644 (file)
--- a/auth2-pam.c
+++ b/auth2-pam.c
@@ -1,5 +1,5 @@
 #include "includes.h"
-RCSID("$Id: auth2-pam.c,v 1.14 2002/06/28 16:48:12 mouring Exp $");
+RCSID("$Id: auth2-pam.c,v 1.15 2003/01/08 01:37:03 djm Exp $");
 
 #ifdef USE_PAM
 #include <security/pam_appl.h>
@@ -154,8 +154,7 @@ input_userauth_info_response_pam(int type, u_int32_t seqnr, void *ctxt)
 
                resp = packet_get_string(&rlen);
                context_pam2.responses[j].resp_retcode = PAM_SUCCESS;
-               context_pam2.responses[j].resp = xstrdup(resp);
-               xfree(resp);
+               context_pam2.responses[j].resp = resp;
                context_pam2.num_received++;
        }