]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
util: Need to check child JSON allocation before use
authorJohn Ferlan <jferlan@redhat.com>
Fri, 18 Jan 2013 14:31:53 +0000 (09:31 -0500)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 22 Jan 2013 13:34:12 +0000 (14:34 +0100)
src/util/virlockspace.c

index 163404f747e6b9c1531b594abd7ab41b4d159e3d..4ff0f3a329c0d09b3334267a1c47cdfd617b3abf 100644 (file)
@@ -459,8 +459,10 @@ virJSONValuePtr virLockSpacePreExecRestart(virLockSpacePtr lockspace)
     virJSONValuePtr resources;
     virHashKeyValuePairPtr pairs = NULL, tmp;
 
-    if (!object)
+    if (!object) {
+        virReportOOMError();
         return NULL;
+    }
 
     virMutexLock(&lockspace->lock);
 
@@ -483,6 +485,11 @@ virJSONValuePtr virLockSpacePreExecRestart(virLockSpacePtr lockspace)
         virJSONValuePtr owners = NULL;
         size_t i;
 
+        if (!child) {
+            virReportOOMError();
+            goto error;
+        }
+
         if (virJSONValueArrayAppend(resources, child) < 0) {
             virJSONValueFree(child);
             goto error;