]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
parser_bison: release helper type string after parsing
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 5 May 2020 18:45:50 +0000 (20:45 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 5 May 2020 18:46:09 +0000 (20:46 +0200)
==4060==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 4 byte(s) in 1 object(s) allocated from:
    #0 0x7f637b64a810 in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x3a810)
    #1 0x7f637b17766d in xstrdup /home/pablo/devel/scm/git-netfilter/nftables/src/utils.c:75
    #2 0x7f637b1ddce9 in nft_parse /home/pablo/devel/scm/git-netfilter/nftables/src/parser_bison.c:5792

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/parser_bison.y

index 0190dbb88c97fe943dc8fba07348bc99f7b17ae3..4369ece60ed0c38cc01b3a3c1c780d432034eb61 100644 (file)
@@ -3903,6 +3903,7 @@ ct_helper_config          :       TYPE    QUOTED_STRING   PROTOCOL        ct_l4protoname  stmt_separator
                                        erec_queue(error(&@2, "invalid name '%s', max length is %u\n", $2, (int)sizeof(ct->name)), state->msgs);
                                        YYERROR;
                                }
+                               xfree($2);
 
                                ct->l4proto = $4;
                        }