]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf: Only dump the throttle log for the leader
authorKan Liang <kan.liang@linux.intel.com>
Tue, 20 May 2025 18:16:30 +0000 (11:16 -0700)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 21 May 2025 11:57:43 +0000 (13:57 +0200)
The PERF_RECORD_THROTTLE records are dumped for all throttled events.
It's not necessary for group events, which are throttled altogether.

Optimize it by only dump the throttle log for the leader.

The sample right after the THROTTLE record must be generated by the
actual target event. It is good enough for the perf tool to locate the
actual target event.

Suggested-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20250520181644.2673067-3-kan.liang@linux.intel.com
kernel/events/core.c

index 8327ab0ee641c77e7f3c9c1bf6e4d604ebf338cd..f34c99f8ce8f446a659cb82f434b7673a3e597a4 100644 (file)
@@ -2650,14 +2650,16 @@ static void perf_event_unthrottle(struct perf_event *event, bool start)
        event->hw.interrupts = 0;
        if (start)
                event->pmu->start(event, 0);
-       perf_log_throttle(event, 1);
+       if (event == event->group_leader)
+               perf_log_throttle(event, 1);
 }
 
 static void perf_event_throttle(struct perf_event *event)
 {
        event->pmu->stop(event, 0);
        event->hw.interrupts = MAX_INTERRUPTS;
-       perf_log_throttle(event, 0);
+       if (event == event->group_leader)
+               perf_log_throttle(event, 0);
 }
 
 static void perf_event_unthrottle_group(struct perf_event *event, bool skip_start_event)