]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
scsi: a3000: Mark driver struct with __refdata to prevent section mismatch
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 29 Mar 2024 21:11:41 +0000 (22:11 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 6 Apr 2024 01:11:44 +0000 (21:11 -0400)
As described in the added code comment, a reference to .exit.text is ok for
drivers registered via module_platform_driver_probe(). Make this explicit
to prevent the following section mismatch warning

WARNING: modpost: drivers/scsi/a3000: section mismatch in reference: amiga_a3000_scsi_driver+0x8 (section: .data) -> amiga_a3000_scsi_remove (section: .exit.text)

that triggers on an allmodconfig W=1 build.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/c7222ad7f0baaff78b19f16e789726d42515f025.1711746359.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/a3000.c

index 378906f77909b1ff1f6442612148c8a31ff7eca6..ad39797890e59a004f96c8e2d35e0e0482f08b7a 100644 (file)
@@ -295,7 +295,13 @@ static void __exit amiga_a3000_scsi_remove(struct platform_device *pdev)
        release_mem_region(res->start, resource_size(res));
 }
 
-static struct platform_driver amiga_a3000_scsi_driver = {
+/*
+ * amiga_a3000_scsi_remove() lives in .exit.text. For drivers registered via
+ * module_platform_driver_probe() this is ok because they cannot get unbound at
+ * runtime. So mark the driver struct with __refdata to prevent modpost
+ * triggering a section mismatch warning.
+ */
+static struct platform_driver amiga_a3000_scsi_driver __refdata = {
        .remove_new = __exit_p(amiga_a3000_scsi_remove),
        .driver   = {
                .name   = "amiga-a3000-scsi",