]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: vme_user: fix location monitor leak in fake bridge
authorHao-Qun Huang <alvinhuang0603@gmail.com>
Sat, 4 Jul 2026 06:58:15 +0000 (14:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 7 Jul 2026 11:41:49 +0000 (13:41 +0200)
fake_init() allocates a location monitor resource and links it into
fake_bridge->lm_resources. The init error path frees this list, but
fake_exit() only frees the slave and master resource lists. Loading
and unloading the module therefore triggers a kmemleak warning:

  unreferenced object 0xffff8b8b82aebe40 (size 64):
    comm "init", pid 1, jiffies 4294894572
    backtrace (crc c1e013ef):
      kmemleak_alloc+0x4e/0x90
      __kmalloc_cache_noprof+0x338/0x430
      0xffffffffc0602246
      do_one_initcall+0x4f/0x320
      do_init_module+0x68/0x270
      load_module+0x2a3b/0x2d90

Free the lm_resources list in fake_exit() as well, before fake_bridge
is freed.

Fixes: 658bcdae9c67 ("vme: Adding Fake VME driver")
Cc: stable <stable@kernel.org>
Cc: Martyn Welch <martyn@welchs.me.uk>
Assisted-by: Claude:claude-fable-5
Signed-off-by: Hao-Qun Huang <alvinhuang0603@gmail.com>
Link: https://patch.msgid.link/20260704065817.403111-1-alvinhuang0603@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vme_user/vme_fake.c

index 8abaa3165fbb7bc8920e331590c2f0f847ad736f..434cf760ade6c82eb70db51d86dff658621bf894 100644 (file)
@@ -1239,6 +1239,7 @@ static void __exit fake_exit(void)
 {
        struct list_head *pos = NULL;
        struct list_head *tmplist;
+       struct vme_lm_resource *lm;
        struct vme_master_resource *master_image;
        struct vme_slave_resource *slave_image;
        int i;
@@ -1268,6 +1269,13 @@ static void __exit fake_exit(void)
        vme_unregister_bridge(fake_bridge);
 
        fake_crcsr_exit(fake_bridge);
+       /* resources are stored in link list */
+       list_for_each_safe(pos, tmplist, &fake_bridge->lm_resources) {
+               lm = list_entry(pos, struct vme_lm_resource, list);
+               list_del(pos);
+               kfree(lm);
+       }
+
        /* resources are stored in link list */
        list_for_each_safe(pos, tmplist, &fake_bridge->slave_resources) {
                slave_image = list_entry(pos, struct vme_slave_resource, list);