]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amd/display: Fix swapped dimension calculations
authorJoshua Aberback <joshua.aberback@amd.com>
Mon, 13 May 2024 18:05:58 +0000 (14:05 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 5 Jun 2024 15:05:14 +0000 (11:05 -0400)
[Why]
The values calculated in optc1_get_otg_active_size are assigned to the
wrong output parameters, vertical blank is being used for horizontal size
and vice versa. This results in DPG test pattern looking wrong during
hardware init, as the DPG dimensions get assigned from this output, and
potentially other issues.

Reviewed-by: Aric Cyr <aric.cyr@amd.com>
Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com>
Signed-off-by: Joshua Aberback <joshua.aberback@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/optc/dcn10/dcn10_optc.c

index 03140e7372d96b4badebd5f80981d6af5245b3e0..336488c0574e51b33c20bafced37c793a9dd94bc 100644 (file)
@@ -1423,8 +1423,8 @@ bool optc1_get_otg_active_size(struct timing_generator *optc,
                        OTG_H_BLANK_START, &h_blank_start,
                        OTG_H_BLANK_END, &h_blank_end);
 
-       *otg_active_width = v_blank_start - v_blank_end;
-       *otg_active_height = h_blank_start - h_blank_end;
+       *otg_active_width = h_blank_start - h_blank_end;
+       *otg_active_height = v_blank_start - v_blank_end;
        return true;
 }