lib-dcrypt: test-stream.c - Remove pointer arithmetic in test_read_garbage()

Something is wrong with the pointer arithmetic given to random_fill(),
and easiest is to remove it altogether. This fixes a valgrind complaint
on use of uninitialized value.

diff --git a/src/lib-dcrypt/test-stream.c b/src/lib-dcrypt/test-stream.c
index 8ec0a34581b89601fd360dd7ac22c7c6bfffd0bd..74725fc25648cdcbbb517df8f948e6316855a569 100644 (file)
--- a/src/lib-dcrypt/test-stream.c
+++ b/src/lib-dcrypt/test-stream.c
@@ -595,9 +595,9 @@ static void test_read_garbage(void)
        test_begin("test_read_garbage");
        unsigned char buf[512];
        for (int i = 0; i < 5; i++) {
+               random_fill(buf, sizeof(buf));
                memcpy(buf, IOSTREAM_CRYPT_MAGIC, sizeof(IOSTREAM_CRYPT_MAGIC));
                buf[sizeof(IOSTREAM_CRYPT_MAGIC)+1] = '\x02';
-               random_fill(buf + 10, sizeof(buf) - 10);
                struct istream *is = test_istream_create_data(buf, sizeof(buf));
                struct istream *ds = i_stream_create_decrypt_callback(is,
                                        no_op_cb, NULL);