]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs: remove unused deferred ops committed field
authorBrian Foster <bfoster@redhat.com>
Fri, 5 Oct 2018 02:36:10 +0000 (21:36 -0500)
committerEric Sandeen <sandeen@redhat.com>
Fri, 5 Oct 2018 02:36:10 +0000 (21:36 -0500)
Source kernel commit: 83200bfac6082a46cc962366478d050052e50450

dop_committed is set when deferred item processing rolls the
transaction at least once, but is only ever accessed in tracepoints.
The transaction roll/commit events are already available via
independent tracepoints, so remove the otherwise unused field.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/xfs_defer.c
libxfs/xfs_defer.h

index bdc6db46330451096bf19621bc474799ead8b907..ba73b89013ecf6f71195abc19c5d4b2f0aab6402 100644 (file)
@@ -249,7 +249,6 @@ xfs_defer_trans_roll(
                xfs_defer_trans_abort(*tp, dop, error);
                return error;
        }
-       dop->dop_committed = true;
 
        /* Rejoin the joined inodes. */
        for (i = 0; i < XFS_DEFER_OPS_NR_INODES && dop->dop_inodes[i]; i++)
index c17c9deda99596b24ef4c49ae081c637637a8095..58c979c9f3fadefbff985afd9f7ff383b038e53f 100644 (file)
@@ -49,7 +49,6 @@ enum xfs_defer_ops_type {
 #define XFS_DEFER_OPS_NR_BUFS  2       /* join up to two buffers */
 
 struct xfs_defer_ops {
-       bool                    dop_committed;  /* did any trans commit? */
        bool                    dop_low;        /* alloc in low mode */
        struct list_head        dop_intake;     /* unlogged pending work */
        struct list_head        dop_pending;    /* logged pending work */